Post round hyperfixation fixes: Mostly examine related stuff (#798)

Author: MrMelbert

code/__DEFINES/_flags.dm

@@ -202,12 +202,14 @@ GLOBAL_LIST_INIT(bitflags, list(1, 2, 4, 8, 16, 32, 64, 128, 256, 512, 1024, 204
 #define ZAP_FUSION_FLAGS ZAP_OBJ_DAMAGE | ZAP_MOB_DAMAGE | ZAP_MOB_STUN
 #define ZAP_SUPERMATTER_FLAGS ZAP_GENERATES_POWER
 
-///EMP will protect itself.
+///Object will protect itself.
 #define EMP_PROTECT_SELF (1<<0)
-///EMP will protect the contents from also being EMPed.
+///Object will protect its contents from being EMPed.
 #define EMP_PROTECT_CONTENTS (1<<1)
-///EMP will protect the wires.
+///Object will protect its wiring from being EMPed.
 #define EMP_PROTECT_WIRES (1<<2)
+///Don't indicate EMP protection in object examine text.
+#define EMP_NO_EXAMINE (1<<3)
 
 ///Protects against all EMP types.
 #define EMP_PROTECT_ALL (EMP_PROTECT_SELF | EMP_PROTECT_CONTENTS | EMP_PROTECT_WIRES)

code/__DEFINES/atmospherics/atmos_machinery.dm

@@ -89,3 +89,6 @@
 #define CAN_MAX_RELEASE_PRESSURE (ONE_ATMOSPHERE * 25)
 ///Min allowed pressure for canisters to release air per tick
 #define CAN_MIN_RELEASE_PRESSURE (ONE_ATMOSPHERE * 0.1)
+
+#define FIRELOCK_FAULT_NAME(tag) "Firelock [tag]"
+#define FIREALARM_FAULT_NAME(tag) "Fire Alarm [tag]"

code/__DEFINES/rotation.dm

@@ -8,6 +8,8 @@
 #define ROTATION_NO_FLIPPING (1<<3)
 /// If an object needs to have an empty spot available in target direction (used for windoors and railings)
 #define ROTATION_NEEDS_ROOM (1<<4)
+/// The turf the object is on needs to be unblocked for the rotation to occur
+#define ROTATION_NEEDS_UNBLOCKED (1<<5)
 
 /// Rotate an object clockwise
 #define ROTATION_CLOCKWISE -90

code/__DEFINES/time.dm

@@ -172,3 +172,6 @@ When using time2text(), please use "DDD" to find the weekday. Refrain from using
 
 /// Anywhere on Earth
 #define TIMEZONE_ANYWHERE_ON_EARTH -12
+
+/// in the grim darkness of the thirteenth space station there is no timezones, since they break IC game times. Use this for all IC/round time values
+#define NO_TIMEZONE 0

code/_onclick/hud/new_player.dm

@@ -606,6 +606,8 @@
 	if(SStitle.stats_faded || !hud?.mymob?.client?.prefs?.read_preference(/datum/preference/toggle/show_init_stats))
 		alpha = 0 // we still need to init it incase they turn it back on
 
+INITIALIZE_IMMEDIATE(/atom/movable/screen/lobby_music)
+
 /atom/movable/screen/lobby_music
 	icon = 'maplestation_modules/icons/hud/lobby_spinner.dmi'
 	icon_state = "spinner"
@@ -635,9 +637,10 @@
 	start_time = world.time
 	end_time = start_time + SSticker.login_length
 	START_PROCESSING(SSlobby_music_player, src)
+	update_maptext()
 
 /atom/movable/screen/lobby_music/process(seconds_per_tick)
-	maptext = "[SStitle.music_maptext]<br>[MAPTEXT("\u25B6 [time2text(min(world.time - start_time, SSticker.login_length), "mm:ss", 0)] / [time2text(SSticker.login_length, "mm:ss", 0)]s")]"
+	update_maptext()
 	if(world.time >= end_time)
 		animate(src, alpha = 0, time = 5 SECONDS)
 		return PROCESS_KILL
@@ -646,6 +649,9 @@
 	STOP_PROCESSING(SSlobby_music_player, src)
 	animate(src, alpha = 0, time = 1 SECONDS)
 
+/atom/movable/screen/lobby_music/proc/update_maptext()
+	maptext = "[SStitle.music_maptext]<br>[MAPTEXT("\u25B6 [time2text(max(10, min(world.time - start_time, SSticker.login_length)), "mm:ss", NO_TIMEZONE)] / [time2text(max(100, SSticker.login_length), "mm:ss", 0)]s")]"
+
 /atom/movable/screen/lobby_music/Destroy()
 	STOP_PROCESSING(SSlobby_music_player, src)
 	return ..()

code/controllers/subsystem/ticker.dm

@@ -786,7 +786,7 @@ SUBSYSTEM_DEF(ticker)
 		return
 
 	login_music = new_music
-	login_length = rustg_sound_length(new_music)
+	login_length = rustg_sound_length(new_music) || 1500 // default to 2.5 minutes if we can't get the length
 	var/list/music_file_components = splittext(new_music, "/")
 	var/music_file_name = length(music_file_components) && music_file_components[length(music_file_components)] || new_music
 	var/list/music_name_components = splittext(music_file_name, "+")

code/datums/components/food/edible.dm

@@ -75,6 +75,7 @@ Behavior that's still missing from this component that original food items had t
 
 /datum/component/edible/RegisterWithParent()
 	RegisterSignal(parent, COMSIG_ATOM_EXAMINE, PROC_REF(examine))
+	RegisterSignal(parent, COMSIG_ATOM_EXAMINE_TAGS, PROC_REF(examine_tags))
 	RegisterSignal(parent, COMSIG_ATOM_ATTACK_ANIMAL, PROC_REF(UseByAnimal))
 	RegisterSignal(parent, COMSIG_ATOM_CHECKPARTS, PROC_REF(OnCraft))
 	RegisterSignal(parent, COMSIG_OOZE_EAT_ATOM, PROC_REF(on_ooze_eat))
@@ -110,6 +111,7 @@ Behavior that's still missing from this component that original food items had t
 		COMSIG_ITEM_USED_AS_INGREDIENT,
 		COMSIG_OOZE_EAT_ATOM,
 		COMSIG_ATOM_EXAMINE,
+		COMSIG_ATOM_EXAMINE_TAGS,
 	))
 
 	qdel(GetComponent(/datum/component/connect_loc_behalf))
@@ -214,9 +216,6 @@ Behavior that's still missing from this component that original food items had t
 	var/atom/owner = parent
 	if(food_flags & FOOD_NO_EXAMINE)
 		return
-	if(foodtypes)
-		var/list/types = bitfield_to_list(foodtypes, FOOD_FLAGS)
-		examine_list += span_notice("It is [LOWER_TEXT(english_list(types))].")
 
 	var/quality = get_perceived_food_quality(user)
 	if(quality > 0)
@@ -231,7 +230,7 @@ Behavior that's still missing from this component that original food items had t
 	else
 		examine_list += span_warning("You find this meal inedible.")
 
-	if(owner.reagents.total_volume > 0)
+	if(owner.reagents.total_volume > 0 && HAS_TRAIT(owner, TRAIT_FOOD_CHEF_MADE))
 		var/purity = owner.reagents.get_average_purity(/datum/reagent/consumable)
 		switch(purity)
 			if(0 to 0.2)
@@ -275,6 +274,14 @@ Behavior that's still missing from this component that original food items had t
 		var/mob/living/living_user = user
 		living_user.taste(owner.reagents)
 
+/datum/component/edible/proc/examine_tags(datum/source, mob/user, list/examine_tags)
+	SIGNAL_HANDLER
+
+	if(food_flags & FOOD_NO_EXAMINE)
+		return
+	for(var/foodtype in bitfield_to_list(foodtypes, FOOD_FLAGS))
+		examine_tags[LOWER_TEXT(foodtype)] = "It's \a [LOWER_TEXT(foodtype)] food."
+
 /datum/component/edible/proc/UseFromHand(obj/item/source, mob/living/M, mob/living/user)
 	SIGNAL_HANDLER
 

code/datums/components/jukebox.dm

@@ -112,7 +112,11 @@
 
 		if(!length(config_songs))
 			var/datum/track/default/default_track = new()
-			config_songs[default_track.song_name] = default_track
+			config_songs["[default_track.song_name] (Default)"] = default_track
+
+		for(var/datum/track/track_subtype in subtypesof(/datum/track/preset))
+			var/datum/track/new_preset = new(track_subtype)
+			config_songs["[new_preset.song_name] (Lag Free)"] = new_preset
 
 	// returns a copy so it can mutate if desired.
 	return config_songs.Copy()
@@ -404,3 +408,27 @@
 	song_name = "Tintin on the Moon"
 	song_length = 3 MINUTES + 52 SECONDS
 	song_beat = 1 SECONDS
+
+/datum/track/preset/title_zero
+	song_path = 'sound/ambience/title0.ogg'
+	song_name = "Endless Space"
+	song_length = 3 MINUTES + 33 SECONDS
+	song_beat = 2 SECONDS
+
+/datum/track/preset/title_one
+	song_path = 'sound/ambience/title1.mod'
+	song_name = "Flip Flap"
+	song_length = 2 MINUTES + 31 SECONDS
+	song_beat = 1 SECONDS
+
+/datum/track/preset/title_two
+	song_path = 'sound/ambience/title2.ogg'
+	song_name = "Robocop"
+	song_length = 1 MINUTES + 58 SECONDS
+	song_beat = 4 SECONDS
+
+/datum/track/preset/title_three
+	song_path = 'sound/ambience/title3.ogg'
+	song_name = "Tintin on the Moon"
+	song_length = 3 MINUTES + 52 SECONDS
+	song_beat = 1 SECONDS

code/datums/components/rotation.dm

@@ -115,6 +115,13 @@
 			if(!silent)
 				rotated_obj.balloon_alert(user, "can't rotate in that direction!")
 			return FALSE
+
+	if(rotation_flags & ROTATION_NEEDS_UNBLOCKED)
+		var/turf/rotate_turf = get_turf(rotated_obj)
+		if(rotate_turf.is_blocked_turf(source_atom = rotated_obj))
+			if(!silent)
+				rotated_obj.balloon_alert(user, "rotation is blocked!")
+			return FALSE
 	return TRUE
 
 /datum/component/simple_rotation/proc/default_post_rotation(mob/user, degrees)

code/datums/components/simple_bodycam.dm

@@ -23,7 +23,7 @@
 	bodycam.name = camera_name
 	bodycam.c_tag = c_tag
 	if(emp_proof)
-		bodycam.AddElement(/datum/element/empprotection, ALL)
+		bodycam.AddElement(/datum/element/empprotection, EMP_PROTECT_ALL)
 
 	RegisterSignal(parent, COMSIG_MOVABLE_MOVED, PROC_REF(update_cam))
 	RegisterSignal(parent, COMSIG_ATOM_DIR_CHANGE, PROC_REF(rotate_cam))