Skip to content

refactor: split cross-kind y-tag changes into scoped follow-up PRs for safer review #662

@mostronatorcoder

Description

@mostronatorcoder

Context

#653 changed y tags across multiple event domains (orders/info/dispute/admin/dev-fee) in one PR.

Problem

Large cross-kind protocol changes are harder to review and reason about for compatibility impact.

Requested follow-up

  • Define a PR-scope guideline for protocol/tag changes:
    • single-kind PRs preferred, or
    • explicit "cross-kind protocol change" checklist in PR description
  • Add reviewer checklist item for external contract impact (indexers/clients)
  • Add "scope declaration" section template in PR body for protocol changes

Acceptance criteria

  • Contributor docs (or AGENTS.md) include scope guidance
  • Future protocol-tag PRs include explicit scope + compatibility statement

Related

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions