feat: completed removal of encryption reference from all the codebase and docs

Author: arkanoider

Cargo.lock

@@ -77,9 +77,6 @@ clap = { version = "4.5.45", features = ["derive"] }
 lnurl-rs = { version = "0.9.0", default-features = false, features = ["ureq"] }
 once_cell = "1.20.2"
 bitcoin = "0.32.5"
-rpassword = "7.3.1"
-argon2 = "0.5"
-secrecy = "0.10.0"
 dirs = "6.0.0"
 clearscreen = "4.0.1"
 tonic = "0.14.2"

Cargo.toml

@@ -18,8 +18,6 @@ These files are copied to `docker/config/lnd/` during the build process.
   - Used in `compose.yml` for port mapping
   - Example: `export MOSTRO_RELAY_LOCAL_PORT=7000`
 
-- `MOSTRO_DB_PASSWORD`: Not used (database encryption was removed). Kept in `compose.yml` for backward compatibility; can be omitted or left empty.
-
 ## Usage Examples
 
 ### Linux/macOS

docker/ENV_VARIABLES.md

@@ -69,14 +69,12 @@ To build and run the Docker container using Docker Compose, follow these steps:
    make docker-up
    ```
 
-   Or pass it inline:
+   Or set the variable on one line before `make docker-up`:
    ```sh
    MOSTRO_RELAY_LOCAL_PORT=7000 make docker-up
    ```
 
-5. **Note:** Database encryption has been removed. The `MOSTRO_DB_PASSWORD` environment variable (if set in `compose.yml`) is no longer used for the database; you can omit it. For more details about environment variables, see [ENV_VARIABLES.md](ENV_VARIABLES.md).
-
-6. Run the docker compose file:
+5. Run the docker compose file:
 
    ```sh
    make docker-up

docker/README.md

@@ -3,8 +3,6 @@ services:
     build:
       context: ..
       dockerfile: docker/Dockerfile
-    environment:
-      MOSTRO_DB_PASSWORD: ${MOSTRO_DB_PASSWORD-}
     volumes:
       - ./config:/config  # settings.toml and mostro.db
     platform: linux/amd64
@@ -15,8 +13,6 @@ services:
     build:
       context: ..
       dockerfile: docker/dockerfile-startos
-    environment:
-      MOSTRO_DB_PASSWORD: ${MOSTRO_DB_PASSWORD-}
     platform: linux/amd64
     networks:
       - default

docker/compose.yml

@@ -29,67 +29,84 @@ port = 50051
 The RPC interface supports the following admin operations:
 
 ### 1. Cancel Order
+
 Cancel an order as an admin.
 
 **Request:**
+
 - `order_id`: UUID of the order to cancel
 - `request_id`: Optional request identifier
 
 **Response:**
+
 - `success`: Boolean indicating operation success
 - `error_message`: Optional error message if operation failed
 
 ### 2. Settle Order
+
 Settle a disputed order as an admin.
 
 **Request:**
+
 - `order_id`: UUID of the order to settle
 - `request_id`: Optional request identifier
 
 **Response:**
+
 - `success`: Boolean indicating operation success
 - `error_message`: Optional error message if operation failed
 
 ### 3. Add Solver
+
 Add a new dispute solver.
 
 **Request:**
+
 - `solver_pubkey`: Public key of the solver to add (in bech32 format)
 - `request_id`: Optional request identifier
 
 **Response:**
+
 - `success`: Boolean indicating operation success
 - `error_message`: Optional error message if operation failed
 
 ### 4. Take Dispute
+
 Take a dispute for resolution.
 
 **Request:**
+
 - `dispute_id`: UUID of the dispute to take
 - `request_id`: Optional request identifier
 
 **Response:**
+
 - `success`: Boolean indicating operation success
 - `error_message`: Optional error message if operation failed
 
 ### 5. Validate Database Password
-Kept for backward compatibility. Database encryption has been removed; this RPC always succeeds and does not validate a password.
+
+Kept for backward compatibility with older clients. The SQLite database is **not** encrypted and this RPC does **not** validate any password; it always succeeds.
 
 **Request:**
-- `password`: Ignored
-- `request_id`: Optional request identifier
+
+- `password`: Ignored (kept in the protobuf for compatibility only)
 
 **Response:**
+
 - `success`: Always `true`
 - `error_message`: Always `None`
 
 ### 6. Get Version
+
 Retrieve the Mostro daemon version.
 
 **Request:**
+
 - No parameters required
 
 **Response:**
+
 - `version`: String containing the daemon version (from CARGO_PKG_VERSION)
 
 ## Protocol Details

docs/RPC.md

@@ -2,16 +2,16 @@
 
 ## Overview
 
-The `ValidateDbPassword` RPC endpoint is protected against brute-force attacks
-with an in-memory rate limiter that tracks failed attempts per client IP.
+The `ValidateDbPassword` RPC is a **backward-compatibility** stub: the database is
+not encrypted, the `password` field is **ignored**, and the handler always returns
+success after an initial per-IP check in `validate_db_password` (`src/rpc/service.rs`).
 
-## Problem
+An in-memory rate limiter (`src/rpc/rate_limiter.rs`) runs **before** the handler
+processes the request. It can enforce backoff or lockout for a client IP when the
+limiter’s failure state is used; the current handler path records **success** only
+and does not validate passwords.
 
-The `ValidateDbPassword` endpoint is kept for backward compatibility (database
-encryption was removed, so it always succeeds). The rate limiter remains to
-throttle abuse of this endpoint.
-
-See [Issue #569](https://github.com/MostroP2P/mostro/issues/569) for full details.
+See [Issue #569](https://github.com/MostroP2P/mostro/issues/569) for background.
 
 ## Implementation
 
@@ -34,12 +34,12 @@ After a successful validation, the client's failure state is reset.
 
 ### Integration (`src/rpc/service.rs`)
 
-The `validate_db_password` method now:
+The `validate_db_password` method:
 
 1. Extracts the client's remote address from the gRPC request
-2. Checks the rate limiter — returns `RESOURCE_EXHAUSTED` if locked out
-3. Does not validate a password (database encryption was removed); always succeeds
-4. On success: resets the client's failure state
+2. Runs `check_rate_limit` — may return `RESOURCE_EXHAUSTED` if the limiter denies the IP
+3. Ignores `password` (no database encryption); returns `success: true`
+4. Calls `record_success` on the limiter for that IP
 
 ### Audit Logging
 

docs/RPC_RATE_LIMITING.md

@@ -9,9 +9,7 @@ This guide explains Mostro’s boot sequence and configuration surfaces.
 
 ## Pre-Boot Initialization
 
-**Lines 33-48 in src/main.rs**:
-
-Before settings initialization, the daemon performs:
+Before settings initialization, the daemon performs (see `src/main.rs`):
 
 1. **Screen clearing**: Clears terminal for clean output
 2. **Logging setup**:
@@ -86,8 +84,8 @@ Configuration is loaded from `~/.mostro/settings.toml` (template: `settings.tpl.
 ### Configuration Sections:
 
 **Database** (`src/config/types.rs:21-26`):
-- `url` (String): Database connection URL
-  - Example: `"sqlite://mostro.db"` or `"postgres://user:pass@localhost/dbname"`
+- `url` (String): Database connection URL (Mostro uses SQLite)
+  - Example: `"sqlite://mostro.db"` or `"sqlite://~/.mostro/mostro.db"`
   - Default: `"sqlite://mostro.db"`
 
 **Nostr** (`src/config/types.rs:47-54`):
@@ -148,25 +146,22 @@ Configuration is loaded from `~/.mostro/settings.toml` (template: `settings.tpl.
 
 ## Global Variables
 
-**Source**: `src/config/mod.rs:26-48`
+**Source**: `src/config/mod.rs`
 
 ```rust
-// Settings and configuration
 pub static MOSTRO_CONFIG: OnceLock<Settings> = OnceLock::new();
-
-// Infrastructure connections
 pub static NOSTR_CLIENT: OnceLock<Client> = OnceLock::new();
 pub static LN_STATUS: OnceLock<LnStatus> = OnceLock::new();
 pub static DB_POOL: OnceLock<Arc<sqlx::SqlitePool>> = OnceLock::new();
 
-// Security (MOSTRO_DB_PASSWORD unused; database encryption was removed)
-pub static MOSTRO_DB_PASSWORD: OnceLock<String> = OnceLock::new();
-
-// Message routing
-pub static MESSAGE_QUEUES: LazyLock<Arc<Mutex<HashMap<String, VecDeque<String>>>>> =
-    LazyLock::new(|| Arc::new(Mutex::new(HashMap::new())));
+pub static MESSAGE_QUEUES: LazyLock<MessageQueues> =
+    LazyLock::new(MessageQueues::default);
 ```
 
+(`MessageQueues` holds `Arc<RwLock<…>>` queues for order DMs, cant-do messages, rating events, and restore-session messages.)
+
+There is **no** database password or separate global for SQLite; the daemon opens the file URL from `[database]` in `settings.toml` only.
+
 **Access patterns**:
 - `Settings::get_mostro()` → Mostro settings
 - `Settings::get_ln()` → Lightning settings

docs/STARTUP_AND_CONFIG.md

@@ -21,10 +21,10 @@ async fn main() -> Result<(), Box<dyn std::error::Error>> {
         .await?;
 
     let mut client = AdminServiceClient::new(channel);
-    // Example 0: ValidateDbPassword (backward compatibility; DB encryption removed, always succeeds)
+    // Example 0: ValidateDbPassword — backward-compat only; password is ignored by the server
     println!("Calling ValidateDbPassword (backward-compat endpoint)...");
     let validate_request = tonic::Request::new(ValidateDbPasswordRequest {
-        password: std::env::var("MOSTRO_DB_TEST_PASSWORD").unwrap_or_default(),
+        password: String::new(),
     });
 
     match client.validate_db_password(validate_request).await {

examples/rpc_client.rs

@@ -16,7 +16,7 @@ service AdminService {
   // Take a dispute for resolution
   rpc TakeDispute(TakeDisputeRequest) returns (TakeDisputeResponse);
 
-  // Validate database password (kept for backward compatibility; DB encryption removed)
+  // Backward compatibility only: password is ignored; SQLite is not encrypted
   rpc ValidateDbPassword(ValidateDbPasswordRequest) returns (ValidateDbPasswordResponse);
 
   // Get Mostro version
@@ -71,7 +71,7 @@ message TakeDisputeResponse {
   optional string error_message = 2;
 }
 
-// Validate database password (backward compatibility; no longer used for DB encryption)
+// Backward compatibility: `password` is ignored (no DB encryption)
 message ValidateDbPasswordRequest {
   string password = 1;
 }