Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

添加 RadioGroup 组件的 cancelable 属性,支持取消选中功能 #541

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

5565007
Copy link

@5565007 5565007 commented Aug 20, 2024

🤔 这个 PR 的性质是?(至少选择一个)

  • 日常 bug 修复
  • 新特性提交
  • 站点、文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • TypeScript 定义更新
  • CI/CD 改进
  • 包体积优化
  • 性能优化
  • 功能增强
  • 国际化改进
  • 代码重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

参数 说明 类型 可选值 默认值 最低版本
cancelable 是否可取消 boolean - false $LOWEST_VERSION$

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充

Summary by CodeRabbit

  • 新功能
    • 添加了可取消选择的单选组功能,用户现在可以通过再次点击已选择的选项来取消该选择。
    • 新增了一个演示模块,展示了该单选组的交互功能。
  • 改进
    • 增强了单选组的灵活性,允许用户自定义是否启用取消选择的功能。

Copy link

netlify bot commented Aug 20, 2024

👷 Deploy request for wot-design-uni accepted.

Name Link
🔨 Latest commit 4848dbf
🔍 Latest deploy log https://app.netlify.com/sites/wot-design-uni/deploys/66c47b44db79320008120c02

Copy link

vercel bot commented Aug 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wot-design-uni ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 20, 2024 11:18am

Copy link

coderabbitai bot commented Aug 20, 2024

Walkthrough

此次更改引入了一个可取消选择的单选按钮组功能,提升了用户交互体验。新增的Demo块展示了如何使用wd-radio-group组件,用户可以通过单击已选中的选项来取消选择。相关属性和逻辑的调整确保了组件的灵活性和可用性。

Changes

文件 更改摘要
src/pages/radio/Index.vue 新增演示块,展示可取消的单选按钮组,添加新变量value4以管理选中的按钮状态。
src/uni_modules/wot-design-uni/components/wd-radio-group/types.ts 添加cancelable属性,允许单选组支持取消选择功能,默认值为false
src/uni_modules/wot-design-uni/components/wd-radio-group/wd-radio-group.vue 修改updateValue函数,根据cancelable属性条件性发出更新,允许点击已选项以清除选择。

Poem

在草地上跳跃的小兔子,
新功能让我们乐无比。
单选按钮可取消,
用户体验齐欢笑。
跟随更新的步伐,
让互动变得更精彩! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between febe730 and 4848dbf.

Files selected for processing (3)
  • src/pages/radio/Index.vue (1 hunks)
  • src/uni_modules/wot-design-uni/components/wd-radio-group/types.ts (2 hunks)
  • src/uni_modules/wot-design-uni/components/wd-radio-group/wd-radio-group.vue (1 hunks)
Additional comments not posted (4)
src/uni_modules/wot-design-uni/components/wd-radio-group/types.ts (2)

14-14: 新增属性 cancelable

RadioGroupProvide 类型中添加了可选的 cancelable 布尔属性。这为 wd-radio-group 提供了取消选中功能的支持。


38-38: radioGroupProps 中添加 cancelable 属性。

cancelable 属性的默认值为 false,这意味着默认情况下单选组不允许取消选中。这与预期功能一致。

src/uni_modules/wot-design-uni/components/wd-radio-group/wd-radio-group.vue (1)

43-47: 更新 updateValue 函数以支持取消选中功能。

props.cancelabletrue 且新值与当前 modelValue 相同时,函数会发出空字符串,从而允许取消选中。这种实现方式增强了组件的交互性。

src/pages/radio/Index.vue (1)

51-61: 新增可取消选中的演示块。

这个演示块展示了如何使用 cancelable 属性来实现可取消选中的单选组功能,提供了一个很好的使用示例。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant