Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add advanced plotting recipies #127

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmikhasenko
Copy link

@mmikhasenko mmikhasenko commented Nov 7, 2024

Closes #126

New Plots.jl recipe makes it easy to plot a curve over a histogram.
There are two new functionality:

  • plot(model::Function, WithData(h)): to adjust normalization of the model taking into account the bin width

  • curvedfitwithpulls(h, best_model): a plot recipe for the histogram, model curve and pulls.

  • Tests are passing

  • Documentation is updated

@Moelf
Copy link
Owner

Moelf commented Nov 7, 2024

I'm a bit confused to what do you want.

Do you want to add a Plots.jl only recipe to this package? And the fitting too?

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 53 lines in your changes missing coverage. Please review.

Project coverage is 71.94%. Comparing base (ca99f99) to head (11c0ceb).

Files with missing lines Patch % Lines
ext/FHistPlotsExt.jl 0.00% 53 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (ca99f99) and HEAD (11c0ceb). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (ca99f99) HEAD (11c0ceb)
4 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   77.45%   71.94%   -5.51%     
==========================================
  Files          11       11              
  Lines         825      877      +52     
==========================================
- Hits          639      631       -8     
- Misses        186      246      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmikhasenko
Copy link
Author

Added description to the header. It is a Plots.jl specific recipe. No fitting, just plotting with correct scaling.

@mmikhasenko
Copy link
Author

note: within a recipe, the histograms for pulls are plotted with scatter series type.
When trying to plot a histogram, issue #123 leads to an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Plotting recipe for a curve over a histogram
2 participants