Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure game support won't break if Nexus Mods IDs are corrected #2138

Open
Pickysaurus opened this issue Oct 9, 2024 · 4 comments
Open

Ensure game support won't break if Nexus Mods IDs are corrected #2138

Pickysaurus opened this issue Oct 9, 2024 · 4 comments
Labels
Feature Request User submitted feature request.

Comments

@Pickysaurus
Copy link

Is your feature request related to a problem? Please describe.
Currently, several NXM links use a different ID to the game domain found on the website.

Game Game ID NXM ID
Skyrim SE skyrimspecialedition SkyrimSE
Fallout NV newvegas falloutnv
TESO elderscrollsonline teso

Describe the solution you'd like
To ensure MO2 can handle these IDs if we correct them to match the Game ID.

Additional context
Nexus-Mods/Vortex#16552

@Pickysaurus Pickysaurus added the Feature Request User submitted feature request. label Oct 9, 2024
@Pickysaurus
Copy link
Author

Initial thoughts by @Al12rs suggest this may be a breaking change. If possible please can someone confirm?

@Silarn
Copy link
Member

Silarn commented Oct 9, 2024

I'll have to double check the code because this change could actually make things a little weird. Sounds like the API requests will be unchanged it's just the download links. Those have used the equivalent of the game short name which corresponds with the directory name used by the game. Should be relatively easy to have it parse the Nexus name instead.

@JonathanFeenstra
Copy link
Contributor

Looks like this is already supported, both the shortName (corresponds to the "NXM ID" column) and the nexusName (Game ID) are checked:

nxmInfo.game().compare(gamePlugin->gameNexusName(), Qt::CaseInsensitive) == 0) {

The same goes for the nxmhandler.

@Silarn
Copy link
Member

Silarn commented Oct 9, 2024

Well in that case we should be fine. I guess grab a NXM link and manually change it to the Nexus id variant and see if it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request User submitted feature request.
Projects
None yet
Development

No branches or pull requests

3 participants