From c44ee31e9f50d68cb687d3683ffc91738a819430 Mon Sep 17 00:00:00 2001 From: Jonathan Feenstra <26406078+JonathanFeenstra@users.noreply.github.com> Date: Tue, 15 Oct 2024 11:02:56 +0200 Subject: [PATCH] Prevent crash when opening NXM link before selecting instance (#2144) --- src/moapplication.cpp | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/moapplication.cpp b/src/moapplication.cpp index bf6a4074..f06a85d1 100644 --- a/src/moapplication.cpp +++ b/src/moapplication.cpp @@ -390,8 +390,14 @@ void MOApplication::externalMessage(const QString& message) } } } else if (isNxmLink(message)) { - MessageDialog::showMessage(tr("Download started"), qApp->activeWindow(), false); - m_core->downloadRequestedNXM(message); + if (InstanceManager::singleton().currentInstance()->gamePlugin() == nullptr) { + // This can happen if MO2 is started with the --pick option and no instance has + // been selected yet, in which case m_core will be null. + reportError(tr("You need to select an instance before trying to download mods.")); + } else { + MessageDialog::showMessage(tr("Download started"), qApp->activeWindow(), false); + m_core->downloadRequestedNXM(message); + } } else { cl::CommandLine cl;