From 11522cf700e07a6c39bad45c346e62a73935c083 Mon Sep 17 00:00:00 2001 From: Jeremy Rimpo Date: Sat, 23 Sep 2023 22:12:58 -0500 Subject: [PATCH] Remove unnecessary plugincontainer from settings --- src/settingsdialog.cpp | 4 ++-- src/settingsdialoggeneral.cpp | 5 ++--- src/settingsdialoggeneral.h | 6 +----- 3 files changed, 5 insertions(+), 10 deletions(-) diff --git a/src/settingsdialog.cpp b/src/settingsdialog.cpp index 67c9dd5d4..425a1cb80 100644 --- a/src/settingsdialog.cpp +++ b/src/settingsdialog.cpp @@ -37,8 +37,8 @@ SettingsDialog::SettingsDialog(PluginContainer* pluginContainer, Settings& setti { ui->setupUi(this); - m_tabs.push_back(std::unique_ptr( - new GeneralSettingsTab(settings, m_pluginContainer, *this))); + m_tabs.push_back( + std::unique_ptr(new GeneralSettingsTab(settings, *this))); m_tabs.push_back(std::unique_ptr(new ThemeSettingsTab(settings, *this))); m_tabs.push_back( std::unique_ptr(new ModListSettingsTab(settings, *this))); diff --git a/src/settingsdialoggeneral.cpp b/src/settingsdialoggeneral.cpp index 62b26c2fb..7acaa190b 100644 --- a/src/settingsdialoggeneral.cpp +++ b/src/settingsdialoggeneral.cpp @@ -8,9 +8,8 @@ using namespace MOBase; -GeneralSettingsTab::GeneralSettingsTab(Settings& s, PluginContainer* pluginContainer, - SettingsDialog& d) - : SettingsTab(s, d), m_PluginContainer(pluginContainer) +GeneralSettingsTab::GeneralSettingsTab(Settings& s, SettingsDialog& d) + : SettingsTab(s, d) { // language addLanguages(); diff --git a/src/settingsdialoggeneral.h b/src/settingsdialoggeneral.h index aa11edbb3..6c1ee8670 100644 --- a/src/settingsdialoggeneral.h +++ b/src/settingsdialoggeneral.h @@ -8,8 +8,7 @@ class GeneralSettingsTab : public SettingsTab { public: - GeneralSettingsTab(Settings& settings, PluginContainer* pluginContainer, - SettingsDialog& dialog); + GeneralSettingsTab(Settings& settings, SettingsDialog& dialog); void update(); @@ -21,9 +20,6 @@ class GeneralSettingsTab : public SettingsTab void onEditCategories(); void onResetDialogs(); - -private: - PluginContainer* m_PluginContainer; }; #endif // SETTINGSDIALOGGENERAL_H