Skip to content

Commit 2f39b59

Browse files
committed
Cleaning for C++20/23.
1 parent b7f1772 commit 2f39b59

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

src/extension.h

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,11 +137,16 @@ class QDLLEXPORT IExtension
137137
//
138138
const auto& requirements() const { return m_Requirements; }
139139

140+
public:
140141
virtual ~IExtension() {}
142+
IExtension& operator=(const IExtension&) = delete;
141143

142144
protected:
143145
IExtension(std::filesystem::path path, ExtensionMetaData metadata);
144146

147+
public:
148+
IExtension(const IExtension&) = default;
149+
145150
private:
146151
std::filesystem::path m_Path;
147152
ExtensionMetaData m_MetaData;

src/requirements.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ ExtensionRequirement::ExtensionRequirement(
2323

2424
ExtensionRequirement::~ExtensionRequirement() = default;
2525

26-
bool ExtensionRequirement::check(IOrganizer* organizer) const
26+
bool ExtensionRequirement::check([[maybe_unused]] IOrganizer* organizer) const
2727
{
2828
return true;
2929
}
@@ -45,6 +45,7 @@ ExtensionRequirementFactory::parseRequirements(const ExtensionMetaData& metadata
4545

4646
std::vector<ExtensionRequirement> requirements;
4747
for (const auto& json_requirement : json_requirements.toArray()) {
48+
// TODO
4849
}
4950

5051
return requirements;

0 commit comments

Comments
 (0)