Expose INVALID_HANDLE_VALUE as mobase.INVALID_HANDLE_VALUE. (#131)

* Expose INVALID_HANDLE_VALUE as mobase.INVALID_HANDLE_VALUE.
* Add tests for startApplication() returning INVALID_HANDLE_VALUE.
* Clean tests and generate stub files for them.

Author: Holt59

.github/workflows/linting.yml

@@ -10,13 +10,15 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v3
-      - name: Run clang-format
-        uses: jidicula/clang-format-action@v4.11.0
+      - name: Check format
+        uses: ModOrganizer2/check-formatting-action@master
         with:
-          clang-format-version: "15"
           check-path: "."
       - uses: actions/setup-python@v4
         with:
-          python-version: '3.10'
-      - uses: isort/isort-action@master
-      - uses: psf/black@stable
+          python-version: "3.12"
+      - uses: abatilo/actions-poetry@v2
+      - name: Check format Python tests
+        run: |
+          poetry install --no-root
+          poetry run poe lint

poetry.lock

@@ -0,0 +1,53 @@
+[tool.poetry]
+name = "modorganizer-plugin_python"
+version = "3.0.0"
+description = ""
+authors = ["Mikaël Capelle <[email protected]>"]
+
+[tool.poetry.dependencies]
+python = "^3.12"
+
+[tool.poetry.group.dev.dependencies]
+pyright = "^1.1.369"
+ruff = "^0.2.1"
+poethepoet = "^0.23.0"
+mobase-stubs = { version = "^2.5.1a0", allow-prereleases = true }
+pyqt6 = "^6.7.0"
+pytest = "^8.2.2"
+pybind11-stubgen = "^2.5.1"
+
+[tool.poe.tasks]
+format-imports = "ruff check --select I tests typings --fix"
+format-ruff = "ruff format tests typings"
+format.sequence = ["format-imports", "format-ruff"]
+lint-ruff = "ruff check tests typings"
+lint-ruff-format = "ruff format --check tests typings"
+lint.sequence = ["lint-ruff", "lint-ruff-format"]
+lint.ignore_fail = "return_non_zero"
+
+[tool.ruff]
+target-version = "py312"
+
+[tool.ruff.lint]
+extend-select = ["B", "Q", "I"]
+
+[tool.ruff.lint.isort.sections]
+mobase = ["mobase"]
+mobase_tests = ["mobase_tests"]
+
+[tool.ruff.lint.isort]
+section-order = [
+    "future",
+    "standard-library",
+    "third-party",
+    "first-party",
+    "mobase",
+    "mobase_tests",
+    "local-folder",
+]
+
+[tool.pyright]
+typeCheckingMode = "strict"
+reportMissingTypeStubs = true
+reportMissingModuleSource = false
+pythonPlatform = "Windows"

pyproject.toml

@@ -429,6 +429,9 @@ namespace mo2::python {
 
     void add_iorganizer_classes(py::module_ m)
     {
+        // define INVALID_HANDLE_VALUE for startApplication, etc.
+        m.attr("INVALID_HANDLE_VALUE") = py::int_((std::uintptr_t)INVALID_HANDLE_VALUE);
+
         py::class_<IOrganizer::FileInfo>(m, "FileInfo")
             .def(py::init<>())
             .def_readwrite("filePath", &IOrganizer::FileInfo::filePath)

setup.cfg

@@ -18,7 +18,6 @@ add_test(NAME pytest
 	COMMAND ${CMAKE_CURRENT_BINARY_DIR}/pylibs/bin/pytest.exe ${CMAKE_CURRENT_SOURCE_DIR} -s
 )
 
-set(extra_paths "${UIBASE_PATH}\\;${MO2_INSTALL_PATH}/bin/dlls")
 set_tests_properties(pytest
 	PROPERTIES
 	DEPENDS python-tests

src/mobase/wrappers/basic_classes.cpp

@@ -1,15 +1,14 @@
-# -*- encoding: utf-8 -*-
-
 import os
 import sys
 from pathlib import Path
+from typing import cast
 
 
 def pytest_configure():
     global app
 
-    os.add_dll_directory(Path(os.getenv("QT_ROOT")).joinpath("bin"))
-    os.add_dll_directory(Path(os.getenv("UIBASE_PATH")))
+    os.add_dll_directory(str(Path(cast(str, os.getenv("QT_ROOT"))).joinpath("bin")))
+    os.add_dll_directory(str(os.getenv("UIBASE_PATH")))
 
     from PyQt6.QtWidgets import QApplication