fix: define webkit old used only when version < 2.40 (#334)

prateekmedia · web-flow · commit 22bf4e6db3eb · 2024-06-03T13:53:20.000+08:00
diff --git a/packages/desktop_webview_window/linux/CMakeLists.txt b/packages/desktop_webview_window/linux/CMakeLists.txt
@@ -9,7 +9,6 @@ set(PLUGIN_NAME "desktop_webview_window_plugin")
 find_package(PkgConfig REQUIRED)
 pkg_check_modules(WebKit IMPORTED_TARGET webkit2gtk-4.1) 
 if (NOT WebKit_FOUND)
-  add_compile_definitions(WEBKIT_OLD_USED=1)
   pkg_check_modules(WebKit REQUIRED IMPORTED_TARGET webkit2gtk-4.0)  # for backward compatibility
 endif ()
 
diff --git a/packages/desktop_webview_window/linux/webview_window.cc b/packages/desktop_webview_window/linux/webview_window.cc
@@ -8,6 +8,10 @@
 
 #include "message_channel_plugin.h"
 
+#if WEBKIT_MAJOR_VERSION < 2 || (WEBKIT_MAJOR_VERSION == 2 && WEBKIT_MINOR_VERSION < 40)
+#define WEBKIT_OLD_USED
+#endif
+
 namespace
 {
 

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,10 @@`
`8`	`8`
`9`	`9`	`#include "message_channel_plugin.h"`
`10`	`10`
	`11`	`+#if WEBKIT_MAJOR_VERSION < 2 \|\| (WEBKIT_MAJOR_VERSION == 2 && WEBKIT_MINOR_VERSION < 40)`
	`12`	`+#define WEBKIT_OLD_USED`
	`13`	`+#endif`
	`14`	`+`
`11`	`15`	`namespace`
`12`	`16`	`{`
`13`	`17`