Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRTK3 HandConstraintPalmUp doesn't default to head gaze for uncalibrated users #250

Open
IssueSyncBot opened this issue Aug 21, 2023 · 3 comments
Labels
Package: Input The Project input package is impacted by this issue. Type: Bug A problem with an existing feature that can be fixed with the next patched release.

Comments

@IssueSyncBot
Copy link

IssueSyncBot commented Aug 21, 2023

Original issue opened by:

@camnewnham @camnewnham


Describe the bug

When the app has gaze permission enabled but the user is uncalibrated (declines prompt to calibrate) the Gaze controller remains at the origin, but appears to still be considered active.

As a result, the HandConstraintPalmUp only triggers if the user happens to be looking in the same direction as the default.

https://github.com/microsoft/MixedRealityToolkit-Unity/blob/mrtk3/com.microsoft.mrtk.spatialmanipulation/Solvers/HandConstraintPalmUp.cs#L268-L290

Or have I miswired something?

MRTK 3.0.0-pre.11

MixedRealityOpenXRPlugin 1.5.1


ISSUE MIGRATION

Issue migrated from: microsoft/MixedRealityToolkit-Unity#11092

@IssueSyncBot IssueSyncBot added MRTK3 Package: Input The Project input package is impacted by this issue. Type: Bug A problem with an existing feature that can be fixed with the next patched release. labels Aug 21, 2023
@IssueSyncBot
Copy link
Author

Original comment by:

@camnewnham camnewnham


It seems that InputTrackingState is not None if eyes are untracked (visor flipped up) as well (this does not affect the hand menu, but has other considerations)

@IssueSyncBot
Copy link
Author

Original comment by:

@Zee2 Zee2


HandConstraintPalmUp is being totally re-jiggered in this PR: #10852 . Will be totally redone and optimized for head gaze!

@IssueSyncBot
Copy link
Author

Original comment by:

@camnewnham camnewnham


HandConstraintPalmUp is being totally re-jiggered in this PR: #10852 . Will be totally redone and optimized for head gaze!

Oh, nice! That looks great.

Perhaps the separate (or more appropriate) issue here is that GazeController is reporting a non-None trackingstate when the user isn't calibrated or the eye tracking isn't current (visor flipped up, headset off, etc).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: Input The Project input package is impacted by this issue. Type: Bug A problem with an existing feature that can be fixed with the next patched release.
Projects
None yet
Development

No branches or pull requests

2 participants