Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This song has some breaks #158

Open
remussatala opened this issue Sep 23, 2016 · 12 comments
Open

This song has some breaks #158

remussatala opened this issue Sep 23, 2016 · 12 comments
Milestone

Comments

@remussatala
Copy link

This song has some breaks.
https://www.dropbox.com/s/p0nbes7jys21oho/earthday.mid
It is the difference compared with timidity and fluidsynth. The song can be found here: https://dl.dropboxusercontent.com/u/8126161/GeneralUser_GS_1.47.zip
from here:
http://www.schristiancollins.com/generaluser.php
There are other songs with breaks. If necessary, I will seek.

@remussatala
Copy link
Author

remussatala commented Sep 24, 2016

And this song has breaks:
https://www.dropbox.com/s/3mjpn1dze9g9phw/He1m3.mid
It has been tested with this midi pats:
https://www.dropbox.com/s/kw2cqdrgv3gdebf/midi-pats.7z

@chrisisonwildcode
Copy link
Contributor

Saw this post today, will investigate tomorrow after some much needed me time.

Chris

Sent from my iPhone

On 24 Sep. 2016, at 6:37 pm, remussatala [email protected] wrote:

And this song has breaks:
https://www.dropbox.com/s/3mjpn1dze9g9phw/He1m3.mid
It has been tested with this midi pats:
https://www.dropbox.com/s/92gvb7kdjrndrvl/midi-pats.7z


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@psi29a
Copy link
Member

psi29a commented Sep 24, 2016

Are these type 2 midis or a midi with multiple tracks?

@psi29a
Copy link
Member

psi29a commented Sep 24, 2016

I just tried with fluidsynth and wildmidi.

Fluidsynth finishes from start to finish and progression is smooth. It is about 2m35s
WildMIDI starts well, but around 1m45 is starts break up a bit, finishing up around 2m34s.

devtest says the earthsong.mid is OK.

@psi29a
Copy link
Member

psi29a commented Sep 24, 2016

The reason I ask about what type of midi it is, because using devtest with -n 1, I see quite a few start of tracks with track sizes from 8 to 38 to 50 to 12

Testing: /home/bcurtis/Dropbox/earthday.mid
Header Size: 6
Format: 1
Number of Tracks: 21
Divisions: 120
Start of Track
Track Size: 299
Time 00:0.00000    Meta Event: Trackname
Meta data (8 bytes): 
0x45 E 0x61 a 0x72 r 0x74 t  0x68 h 0x64 d 0x61 a 0x79 y 
Time 00:0.00000    Meta Event: Copyright
Meta data (13 bytes): 
0x43 C 0x72 r 0x65 e 0x61 a  0x74 t 0x69 i 0x76 v 0x65 e  
0x20 0x4c L 0x61 a 0x62 b  0x73 s 
Time 00:0.00000    Meta Event: Time Signature: 04 02 18 08
Meta data (4 bytes): 

@remussatala
Copy link
Author

He1m3.mid (from Heretic game) also it has a small break. There are many songs that have little breaks. It was listened with wildmidi 0.4.0 in arch linux. You think you can fix this problem? I think it is a very old problem.

@chrisisonwildcode
Copy link
Contributor

chrisisonwildcode commented Oct 4, 2016

looking into this right now, listening to it sounds like "all notes off" is done, but looking into it.

Just so I know we are hearing the same thing, at around 1:48 and 1:53 (others as well) the sound stops abruptly. Is this what the OP is about?

@chrisisonwildcode
Copy link
Contributor

Sorry, taking longer than expected due to #160

@psi29a
Copy link
Member

psi29a commented Oct 5, 2016

Just glad you have some time to look into things. :)

@sezero
Copy link
Contributor

sezero commented Oct 12, 2016

I tried earthday.mid with libtimidity-0.2.1: it is 2m.28s long and I didn't experience breaks with it.
Didn't see breaks with He1m3.mid either, it is reported to be 1m:31s.

@sezero sezero added this to the 0.4.2 milestone Mar 17, 2017
@sezero sezero modified the milestones: 0.4.2, 0.4.3 Nov 3, 2017
@chrisisonwildcode
Copy link
Contributor

I'm not hearing any issues with these, unless someone can do a wav output that captures the issue as well as explain what am listening for (and when) that highlights the issue.

@sezero
Copy link
Contributor

sezero commented Sep 13, 2018

Is this still an issue? If it is, is the issue present in wildmidi-0.3.x too?

(Sorry for asking without actually testing myself.)

@sezero sezero modified the milestones: 0.4.3, 0.4.4 Nov 24, 2018
@sezero sezero modified the milestones: 0.4.4, 0.4.5 Mar 21, 2021
@sezero sezero modified the milestones: 0.4.5, 0.4.6 Jan 8, 2023
@sezero sezero modified the milestones: 0.4.6, 0.4.7 Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants