Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Problem/Bug]: creating a webview2 resets HiddenPdfToolbarItems to None #4809

Closed
pushkin- opened this issue Sep 13, 2024 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@pushkin-
Copy link

pushkin- commented Sep 13, 2024

What happened?

Actually, this happens when two webview2 are being created around the same time. Will come back and update all of this and add a minimal example.

The ask is for these settings that apply to all CoreWebView2s. The most-recently set value should be copied into the newly instantiated CoreWebView2Settings objects rather than expecting the application to reset the setting each time

If I set Settings::HiddenPdfToolbarItems to some non-default value and then create another WebView2 with the default settings, HiddenPdfToolbarItems gets reset back to None in all webview2.

Seems like the custom value we set should be preservered when creating other webviews.

Importance

Moderate. My app's user experience is affected, but still usable.

Runtime Channel

Stable release (WebView2 Runtime)

Runtime Version

128.0.2739.67

SDK Version

1.0.2535.41

Framework

Winforms

Operating System

Windows 11

OS Version

22631.4037

Repro steps

create a webview2 and set HiddenPdfToolbarItems to a non-default value.
Then create another webview2 control and see that after calling EnsureWebView2Async on it, the other webview's HiddenPdfToolbarItems gets reset back to the default.

Repros in Edge Browser

No, issue does not reproduce in the corresponding Edge version

Regression

No, this never worked

Last working version (if regression)

No response

@pushkin- pushkin- added the bug Something isn't working label Sep 13, 2024
@pushkin-
Copy link
Author

pushkin- commented Sep 13, 2024

not expressing the issue correctly; will close for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant