fix: allow admins to remove admin, show members without charter

- Remove admin button now visible to all admins, not just owners
- Backend allows admins to revoke admin privileges from other admins
- Members list renders on group page even when no charter exists
- Hide signing status indicators when no charter is present

Author: coodos

platforms/group-charter-manager/api/src/controllers/GroupController.ts

@@ -379,10 +379,7 @@ export class GroupController {
                 const newAdmins = [...currentAdmins, targetUserId];
                 await this.groupService.updateGroup(groupId, { admins: newAdmins } as any);
             } else if (role === "member") {
-                // Remove admin - only owner can do this
-                if (!isOwner) {
-                    return res.status(403).json({ error: "Only the owner can remove admin privileges" });
-                }
+                // Remove admin - admins and owners can do this
                 if (targetUserId === group.owner) {
                     return res.status(400).json({ error: "Cannot demote the owner" });
                 }

platforms/group-charter-manager/client/src/app/charter/[id]/page.tsx

@@ -419,15 +419,13 @@ export default function CharterDetail({
                     )}
 
                     {/* Charter Signing Status */}
-                    {group.charter && (
-                        <CharterSigningStatus
-                            groupId={group.id}
-                            charterContent={group.charter}
-                            currentUserId={user?.id}
-                            currentUserIsAdmin={group.admins?.includes(user?.id || '') || false}
-                            currentUserIsOwner={group.owner === user?.id}
-                        />
-                    )}
+                    <CharterSigningStatus
+                        groupId={group.id}
+                        charterContent={group.charter || ""}
+                        currentUserId={user?.id}
+                        currentUserIsAdmin={group.admins?.includes(user?.id || '') || false}
+                        currentUserIsOwner={group.owner === user?.id}
+                    />
                 </div>
             </div>
 

platforms/group-charter-manager/client/src/components/charter-signing-status.tsx

@@ -134,18 +134,22 @@ export function CharterSigningStatus({ groupId, charterContent, currentUserId, c
                                 className="flex items-center justify-between p-3 bg-gray-50 rounded-lg"
                             >
                                 <div className="flex items-center gap-3">
-                                    {participant.hasSigned ? (
-                                        <CheckCircle className="h-5 w-5 text-green-600" />
-                                    ) : (
-                                        <Circle className="h-5 w-5 text-gray-400" />
-                                    )}
+                                    {charterContent ? (
+                                        participant.hasSigned ? (
+                                            <CheckCircle className="h-5 w-5 text-green-600" />
+                                        ) : (
+                                            <Circle className="h-5 w-5 text-gray-400" />
+                                        )
+                                    ) : null}
                                     <div>
                                         <p className="font-medium text-sm">
                                             {participant.name || participant.ename || 'Unknown User'}
                                         </p>
-                                        <p className="text-xs text-gray-500">
-                                            {participant.hasSigned ? 'Signed' : 'Not signed yet'}
-                                        </p>
+                                        {charterContent && (
+                                            <p className="text-xs text-gray-500">
+                                                {participant.hasSigned ? 'Signed' : 'Not signed yet'}
+                                            </p>
+                                        )}
                                     </div>
                                 </div>
                                 <div className="flex items-center gap-2">
@@ -173,7 +177,7 @@ export function CharterSigningStatus({ groupId, charterContent, currentUserId, c
                                                         Make Admin
                                                     </DropdownMenuItem>
                                                 )}
-                                                {participant.isAdmin && !participant.isOwner && currentUserIsOwner && (
+                                                {participant.isAdmin && !participant.isOwner && (
                                                     <DropdownMenuItem onClick={() => handleRoleChange(participant.id, "member")}>
                                                         <ShieldOff className="mr-2 h-4 w-4" />
                                                         Remove Admin