fix(eid-wallet): clear cached identity data on logout

Author: Bekiboo

infrastructure/eid-wallet/src/routes/(app)/cache.ts

@@ -0,0 +1,28 @@
+/**
+ * Registry of the module-scope render caches that survive logout.
+ *
+ * Pages stash their last-known values at module scope so re-entering paints
+ * instantly instead of flashing a spinner. That state outlives logout:
+ * `performLogout` leaves with `goto("/")`, a client-side navigation, and
+ * SvelteKit never re-evaluates a module on client-side nav. So without an
+ * explicit reset, the next user to onboard on this device is shown the
+ * previous user's data. Same hazard `clearAllCachedPhotos` exists for.
+ *
+ * A page registers its own reset from `<script module>`, which keeps the cache
+ * colocated with the code that fills it. A page that was never visited never
+ * registered — and has nothing cached to leak.
+ */
+const resets = new Set<() => void>();
+
+/** Register a page's cache reset. Call from `<script module>`. */
+export function registerPageCacheReset(reset: () => void): void {
+    resets.add(reset);
+}
+
+/**
+ * Wipe every registered page cache. Call on logout to prevent cross-user data
+ * leaks.
+ */
+export function clearAllPageCaches(): void {
+    for (const reset of resets) reset();
+}

infrastructure/eid-wallet/src/routes/(app)/main/+page.svelte

@@ -11,6 +11,7 @@ let hasMountedBefore = false;
 // instead of flashing the white loading splash. The component still kicks
 // off a fresh fetch on mount; the loaders write back into both the
 // component state and these slots so the next visit is also instant.
+import { registerPageCacheReset } from "../cache";
 import type { LegalIdDoc } from "./components/LegalIdAccordion.svelte";
 import type { SocialBindingDisplay } from "./components/SocialBindingAccordion.svelte";
 
@@ -23,6 +24,24 @@ let cachedSelfDocId: string | undefined;
 let cachedSocialBindingCount = 0;
 let cachedSocialBindingPreview: SocialBindingDisplay[] = [];
 let hasEverLoaded = false;
+
+// All of the above is one user's identity, and none of it survives a logout:
+// that's a client-side nav, which never re-evaluates this module, so the next
+// user to onboard on this device would be shown the previous user's name,
+// legal ID and contacts until the first fetch lands. `hasMountedBefore` goes
+// with them — a fresh session should play the entrance animation again.
+registerPageCacheReset(() => {
+    cachedUserData = undefined;
+    cachedEname = undefined;
+    cachedIsFake = undefined;
+    cachedLegalId = null;
+    cachedDisplayName = undefined;
+    cachedSelfDocId = undefined;
+    cachedSocialBindingCount = 0;
+    cachedSocialBindingPreview = [];
+    hasEverLoaded = false;
+    hasMountedBefore = false;
+});
 </script>
 
 <script lang="ts">

infrastructure/eid-wallet/src/routes/(app)/settings/+page.svelte

@@ -15,6 +15,7 @@ import { isPermissionGranted } from "@choochmeque/tauri-plugin-notifications-api
 import { FaceIdIcon, Notification02Icon } from "@hugeicons/core-free-icons";
 import { checkStatus } from "@tauri-apps/plugin-biometric";
 import { getContext, onMount } from "svelte";
+import { clearAllPageCaches } from "../cache";
 
 const getGlobalState = getContext<() => GlobalState>("globalState");
 const setGlobalState =
@@ -84,6 +85,7 @@ async function performLogout() {
     isLogoutDrawerOpen = false;
     clearAllNotifications();
     await clearAllCachedPhotos();
+    clearAllPageCaches();
     if (!globalState) {
         console.error("Cannot logout: global state not ready");
         return;

infrastructure/eid-wallet/src/routes/(app)/social-bindings/+page.svelte

@@ -1,9 +1,18 @@
 <script module lang="ts">
+import { registerPageCacheReset } from "../cache";
+
 // Survives navigation, like the home screen's caches: returning to this page
 // paints the last known list immediately instead of showing a full-screen
 // spinner while every contact is re-resolved from scratch.
 let cachedContacts: SocialBindingDisplay[] = [];
 let hasEverLoaded = false;
+
+// It survives logout too — that's a client-side nav — so drop it there, or the
+// next user onboarding on this device gets a first paint of these contacts.
+registerPageCacheReset(() => {
+    cachedContacts = [];
+    hasEverLoaded = false;
+});
 </script>
 
 <script lang="ts">