fix: explicit pub priv profile behaviour

Author: sosweetham

platforms/profile-editor/api/src/services/EVaultProfileService.ts

@@ -166,7 +166,7 @@ export class EVaultProfileService {
 				phone: profData.phone,
 				website: profData.website,
 				location: profData.location,
-				isPublic: profData.isPublic !== false, // default to public when not explicitly set
+				isPublic: profData.isPublic === true, // default to public when not explicitly set
 				workExperience: profData.workExperience ?? [],
 				education: profData.education ?? [],
 				skills: profData.skills ?? [],

platforms/profile-editor/api/src/services/EVaultSyncService.ts

@@ -99,7 +99,7 @@ export class EVaultSyncService {
 			avatarFileId: profile.professional.avatarFileId,
 			bannerFileId: profile.professional.bannerFileId,
 			skills: profile.professional.skills,
-			isPublic: profile.professional.isPublic !== false,
+			isPublic: profile.professional.isPublic === true,
 			isArchived: false,
 		});
 	}