fix: lint

Author: coodos

infrastructure/eid-wallet/src/lib/utils/socialBinding.ts

@@ -150,6 +150,7 @@ export async function fetchNameFromVault(
     gqlUrl: string,
     ownerEname: string,
     fallback: string,
+    debug = false,
 ): Promise<string> {
     try {
         const data = await vaultGqlRequest<BindingDocsResult>(
@@ -158,13 +159,15 @@ export async function fetchNameFromVault(
             BINDING_DOCS_QUERY,
         );
         const edges = data.bindingDocuments?.edges ?? [];
-        console.log(
-            `[fetchNameFromVault] X-ENAME=${ownerEname} returned ${edges.length} docs:`,
-            edges.map((e) => ({
-                type: e.node.parsed?.type,
-                name: e.node.parsed?.data?.name,
-            })),
-        );
+        if (debug) {
+            console.debug("[fetchNameFromVault] binding docs fetched", {
+                docsCount: edges.length,
+                docs: edges.map((e) => ({
+                    type: e.node.parsed?.type,
+                    hasName: typeof e.node.parsed?.data?.name === "string",
+                })),
+            });
+        }
         let selfName: string | null = null;
         for (const edge of edges) {
             const parsed = edge.node.parsed;
@@ -414,9 +417,10 @@ export async function fetchUnsignedSocialDocs(
         // so the requester IS the subject of the doc they need to counter-sign.
         if (parsed.subject !== normalized) return false;
         // Requester hasn't counter-signed yet
-        const alreadySigned = parsed.signatures.some(
-            (s) => s.signer === normalized,
-        );
+        const signatures = Array.isArray(parsed.signatures)
+            ? parsed.signatures
+            : [];
+        const alreadySigned = signatures.some((s) => s.signer === normalized);
         return !alreadySigned;
     });
 }
@@ -451,7 +455,10 @@ export async function fetchUnsignedSocialDocForSubject(
         const parsed = edge.node.parsed;
         if (!parsed || parsed.type !== "social_connection") return false;
         if (parsed.subject !== normalizedSubject) return false;
-        const alreadySigned = parsed.signatures.some(
+        const signatures = Array.isArray(parsed.signatures)
+            ? parsed.signatures
+            : [];
+        const alreadySigned = signatures.some(
             (s) => s.signer === normalizedCaller,
         );
         return !alreadySigned;

infrastructure/eid-wallet/src/routes/(app)/ePassport/+page.svelte

@@ -10,10 +10,10 @@ import { ButtonAction } from "$lib/ui";
 import {
     addCounterpartySignature,
     capitalize,
-    getCanonicalBindingDocString,
     deleteSocialBindingDoc,
     fetchNameFromVault,
     fetchUnsignedSocialDocs,
+    getCanonicalBindingDocString,
     resolveVaultUri,
 } from "$lib/utils";
 import axios from "axios";
@@ -498,20 +498,33 @@ async function runSocialBindingPoll() {
 async function confirmSocialBinding() {
     if (!socialBindingSignerEname) return;
     socialBindingAwaitingConsent = false;
-    socialBindingCounterSigning = true;
     socialBindingError = null;
 
+    const vault = await globalState.vaultController.vault;
+    if (!vault?.ename || !vault?.uri) {
+        socialBindingError = "No active vault found.";
+        socialBindingAwaitingConsent = false;
+        socialBindingCounterSigning = false;
+        startSocialBindingPolling();
+        return;
+    }
+
+    if (!socialBindingPendingDocId || !socialBindingPendingDocParsed) {
+        socialBindingError = "No pending social binding request found.";
+        socialBindingAwaitingConsent = false;
+        socialBindingCounterSigning = false;
+        startSocialBindingPolling();
+        return;
+    }
+
+    socialBindingCounterSigning = true;
+
     try {
-        const vault = await globalState.vaultController.vault;
-        if (!vault?.ename || !vault?.uri) return;
         const callerEname = vault.ename.startsWith("@")
             ? vault.ename
             : `@${vault.ename}`;
         const gqlUrl = new URL("/graphql", vault.uri).toString();
 
-        if (!socialBindingPendingDocId || !socialBindingPendingDocParsed)
-            return;
-
         // Counter-sign the doc in the requester's OWN vault.
         // The doc has subject=@requester (=callerEname) so the requester is the valid counterparty.
         const payload = getCanonicalBindingDocString({
@@ -537,9 +550,10 @@ async function confirmSocialBinding() {
         console.error("[Social Binding] counter-sign error:", err);
         socialBindingError =
             err instanceof Error ? err.message : "Something went wrong.";
-        socialBindingCounterSigning = false;
         socialBindingAwaitingConsent = false;
         startSocialBindingPolling();
+    } finally {
+        socialBindingCounterSigning = false;
     }
 }
 

infrastructure/eid-wallet/src/routes/(app)/scan-qr/scanLogic.ts

@@ -15,10 +15,9 @@ import { authenticate } from "wallet-sdk";
 
 import type { GlobalState } from "$lib/global";
 import {
-    addCounterpartySignature,
-    getCanonicalBindingDocString,
     createSocialConnectionDoc,
     fetchNameFromVault,
+    getCanonicalBindingDocString,
     resolveVaultUri,
 } from "$lib/utils";
 
@@ -677,6 +676,15 @@ export function createScanLogic({
             const signerEname = vault.ename.startsWith("@")
                 ? vault.ename
                 : `@${vault.ename}`;
+            const normalizedRequesterEname = requesterEname.startsWith("@")
+                ? requesterEname
+                : `@${requesterEname}`;
+            if (signerEname === normalizedRequesterEname) {
+                socialBindingError.set(
+                    "You cannot create a social binding with yourself.",
+                );
+                return;
+            }
 
             // 1. Resolve requester's vault URI
             const requesterVaultUri = await resolveVaultUri(requesterEname);

platforms/enotary/src/lib/types/svelte-qrcode.d.ts

@@ -1,8 +1,10 @@
 declare module "svelte-qrcode" {
-    import type { SvelteComponentTyped } from "svelte";
+    import type { Component } from "svelte";
 
-    export default class QrCode extends SvelteComponentTyped<{
+    export declare const QrCode: Component<{
         value: string;
         size?: number;
-    }> {}
+    }>;
+
+    export default QrCode;
 }