Skip to content

Conversation

@Nodonisko
Copy link
Contributor

@Nodonisko Nodonisko commented Nov 17, 2025

This PR adds tests and benchmark to example app for getPublicKeyEd25519 function.

Contains:

  1. Tests ported directly from @noble/curves library
  2. Direct comparison tests of results from JS only @noble/curves library and our C++ implementation
  3. Our custom tests
Screenshot_1762345083 Screenshot_1762345051

@Nodonisko Nodonisko requested a review from a team as a code owner November 17, 2025 19:28
@Nodonisko Nodonisko force-pushed the feat/get-public-key-ed25519-tests branch 2 times, most recently from 3f22037 to 72b2aa0 Compare November 17, 2025 19:32
@Nodonisko Nodonisko force-pushed the feat/get-public-key-ed25519-tests branch from b662ff9 to 0c52831 Compare November 26, 2025 08:34
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman merged commit e49ba83 into MetaMask:main Nov 26, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants