Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove unnecessary resolutions #30446

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Feb 19, 2025

Description

All Yarn resolutions with no impact on the lockfile have been removed. Any patches used solely by removed resolutions have been removed as well.

These resolutions were applied to versions of dependencies no longer in-use, so they had zero impact. Removing them has no effect.

The one exception is await-semaphore, where an additional resolution was needed because the dependencies entry was slightly behind the version being patched. The dependency entry was updated, making that resolution unnecessary. This is where the sole lockfile change comes from. Still zero functional impact.

Open in GitHub Codespaces

Related issues

N/A

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Gudahtt Gudahtt force-pushed the remove-unnecessary-resolutions-and-patches branch 2 times, most recently from 96c8106 to e49f12a Compare February 19, 2025 21:44
All Yarn resolutions with no impact on the lockfile have been removed.
Any patches used solely by removed resolutions have been removed as
well.

These resolutions were applied to versions of dependencies no longer
in-use, so they had zero impact. Removing them has no effect.

The one exception is `await-semaphore`, where the resolution had the
impact of overriding the `dependencies` entry in this project for that
dependency. The dependency entry was updated, making that resolution
unnecessary. This is where the sole lockfile change comes from.
@Gudahtt Gudahtt force-pushed the remove-unnecessary-resolutions-and-patches branch from e49f12a to 0c012f5 Compare February 19, 2025 21:44
@Gudahtt Gudahtt marked this pull request as ready for review February 19, 2025 21:48
Copy link
Contributor

@davidmurdoch davidmurdoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (as long as CI passes :-p )

@DDDDDanica
Copy link
Contributor

LGTM !

@Gudahtt Gudahtt enabled auto-merge February 19, 2025 21:55
@Gudahtt Gudahtt added this pull request to the merge queue Feb 19, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [0c012f5]
Page Load Metrics (1759 ± 74 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27322561612454218
domContentLoaded15562162173514570
load15652197175915474
domInteractive1793482512
backgroundConnect107225199
firstReactRender1577402512
getState45014157
initialActions00000
loadScripts11161613125912058
setupStore780172010
uiStartup181426412034218105
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into main with commit 0e3f87d Feb 19, 2025
85 checks passed
@Gudahtt Gudahtt deleted the remove-unnecessary-resolutions-and-patches branch February 19, 2025 22:52
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2025
@metamaskbot metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.14.0 Issue or pull request that will be included in release 12.14.0 team-wallet-framework
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants