Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix spinner display in NFT tab #30427

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Feb 19, 2025

Description

Fix spinner display in NFt tab.

No functional changes

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to nft tab
  2. Spinner should be centered

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri marked this pull request as ready for review February 19, 2025 11:52
@sahar-fehri sahar-fehri added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Feb 19, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [01ea1e1]
Page Load Metrics (1809 ± 91 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint44521551659440211
domContentLoaded14762148178018790
load15012155180918991
domInteractive2496472010
backgroundConnect877292110
firstReactRender1476412512
getState46617189
initialActions0442105
loadScripts10471708131417182
setupStore86018168
uiStartup171424582076218105
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 210 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@sahar-fehri sahar-fehri added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit a19a398 Feb 19, 2025
88 checks passed
@sahar-fehri sahar-fehri deleted the fix/fix-spinner-display branch February 19, 2025 16:43
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2025
@metamaskbot metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-12.14.0 Issue or pull request that will be included in release 12.14.0 team-assets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants