Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove circular dependency between actions.ts and swaps.util.ts #30306

Merged
merged 6 commits into from
Feb 19, 2025

Conversation

davidmurdoch
Copy link
Contributor

@davidmurdoch davidmurdoch commented Feb 13, 2025

This PR solves an issue with circular dependencies. It does not change the behavior of the application. It only rearranges functions/files to avoid circular references.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-extension-platform Extension Platform team label Feb 13, 2025
@davidmurdoch davidmurdoch changed the title refactor: remove circular dependency between actions.ts and swaps.utils.ts refactor: remove circular dependency between actions.ts and swaps.util.ts Feb 14, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [4419bb8]
Page Load Metrics (1647 ± 56 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint36818991570296142
domContentLoaded14471864162011153
load14611903164711756
domInteractive19135382713
backgroundConnect871302110
firstReactRender1466282010
getState421942
initialActions00000
loadScripts1003138211688842
setupStore764222110
uiStartup16752411190316880
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 432 Bytes (0.00%)

@davidmurdoch davidmurdoch marked this pull request as ready for review February 14, 2025 19:01
@davidmurdoch davidmurdoch requested review from a team, HowardBraham and dbrans as code owners February 14, 2025 19:01
@metamaskbot
Copy link
Collaborator

Builds ready [4182372]
Page Load Metrics (1688 ± 87 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint20920461628368177
domContentLoaded14271999166917383
load14352067168818187
domInteractive2387482211
backgroundConnect895232211
firstReactRender1473402311
getState57415189
initialActions01000
loadScripts9621505120115675
setupStore76519199
uiStartup16132281191919393
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 432 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [d3ddd44]
Page Load Metrics (1706 ± 76 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint37520211631327157
domContentLoaded14421946167415675
load14771987170615876
domInteractive2493402211
backgroundConnect1078332110
firstReactRender146924189
getState55920199
initialActions00000
loadScripts9931474121213866
setupStore86119199
uiStartup16952220193916579
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 432 Bytes (0.00%)

@davidmurdoch davidmurdoch added this pull request to the merge queue Feb 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 19, 2025
@davidmurdoch davidmurdoch added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit e04e2f7 Feb 19, 2025
79 checks passed
@davidmurdoch davidmurdoch deleted the circles-swaps-util branch February 19, 2025 20:49
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2025
@metamaskbot metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.14.0 Issue or pull request that will be included in release 12.14.0 team-extension-platform Extension Platform team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants