Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set swap input parameters #30284

Merged
merged 3 commits into from
Feb 19, 2025
Merged

chore: set swap input parameters #30284

merged 3 commits into from
Feb 19, 2025

Conversation

micaelae
Copy link
Member

@micaelae micaelae commented Feb 12, 2025

Description

Modifying bridge input component logic to allow fetching swap quotes

Open in GitHub Codespaces

Related issues

Fixes:NA

Manual testing steps

  1. Load flask build and activate non-EVM chain
  2. Click "Swap"
  3. Page should match Swap mocks (using Bridge ui)
  4. Select dest token
  5. "Switch inputs" button should be enabled and switch token selections on click
  6. Verify that quotes are fetched in the background
  7. Bridge experience should not be affected

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@micaelae micaelae marked this pull request as ready for review February 12, 2025 23:31
@micaelae micaelae requested a review from a team as a code owner February 12, 2025 23:31
@metamaskbot
Copy link
Collaborator

Builds ready [10c2a61]
Page Load Metrics (1632 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1474189016399948
domContentLoaded1465183316068742
load1474189616329646
domInteractive22101432613
backgroundConnect866292110
firstReactRender1698482613
getState457212110
initialActions01000
loadScripts1003139511519344
setupStore713921
uiStartup16722149186712258
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -39 Bytes (-0.00%)
  • ui: 120 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [da0c4ad]
Page Load Metrics (1589 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14311887159111254
domContentLoaded14251831156710952
load14301900158911254
domInteractive16106372512
backgroundConnect772232010
firstReactRender1396412713
getState44712136
initialActions01000
loadScripts1006135411379345
setupStore76711136
uiStartup16712097182112259
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -39 Bytes (-0.00%)
  • ui: 120 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@micaelae micaelae enabled auto-merge February 18, 2025 20:32
@micaelae micaelae force-pushed the mms1867-swap-inputs branch from da0c4ad to 9efe9f9 Compare February 19, 2025 16:27
@metamaskbot
Copy link
Collaborator

Builds ready [9efe9f9]
Page Load Metrics (1651 ± 39 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint26918221578312150
domContentLoaded1478181216278139
load1499182416518239
domInteractive2499442311
backgroundConnect885272512
firstReactRender1467382211
getState45519189
initialActions01000
loadScripts1046134011827838
setupStore76317189
uiStartup17522255191011555
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -39 Bytes (-0.00%)
  • ui: 120 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@micaelae micaelae disabled auto-merge February 19, 2025 18:25
@micaelae micaelae added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit 67aa6aa Feb 19, 2025
79 checks passed
@micaelae micaelae deleted the mms1867-swap-inputs branch February 19, 2025 19:01
@github-actions github-actions bot locked and limited conversation to collaborators Feb 19, 2025
@metamaskbot metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.14.0 Issue or pull request that will be included in release 12.14.0 team-bridge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants