Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick: default network selection logic in connection flow (#30139) #30146

Conversation

adonesky1
Copy link
Contributor

@adonesky1 adonesky1 commented Feb 5, 2025

Fixes a small gap left by this
fix

BEFORE:

Screen.Recording.2025-02-05.at.10.48.27.AM.mov

AFTER:

Screen.Recording.2025-02-05.at.10.52.19.AM.mov

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@adonesky1 adonesky1 changed the title fix: default network selection logic in connection flow (#30139) cherry-pick: default network selection logic in connection flow (#30139) Feb 5, 2025
Copy link
Contributor

github-actions bot commented Feb 5, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [8f638b3]
Page Load Metrics (1803 ± 116 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint29326641733414199
domContentLoaded141326101781244117
load142226191803242116
domInteractive229837199
backgroundConnect86727189
firstReactRender1697452813
getState45319199
initialActions01000
loadScripts98821861319241116
setupStore85717168
uiStartup164329182091277133

@itsyoboieltr itsyoboieltr merged commit b216ace into Version-v12.12.0 Feb 6, 2025
70 checks passed
@itsyoboieltr itsyoboieltr deleted the ad/cherry-pick-v12.12.0-default-network-selection branch February 6, 2025 06:07
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants