Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove Snaps insight dead code #30130

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Feb 5, 2025

Description

Removes dead Snaps code following the removal of the old confirmation screens.

Open in GitHub Codespaces

Manual testing steps

N/A

@FrederikBolding FrederikBolding requested review from a team as code owners February 5, 2025 12:38
@metamaskbot metamaskbot added team-snaps-platform Snaps Platform team INVALID-PR-TEMPLATE PR's body doesn't match template labels Feb 5, 2025
Copy link
Member

@Mrtenz Mrtenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@FrederikBolding FrederikBolding added this pull request to the merge queue Feb 5, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [199a796]
Page Load Metrics (1681 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint22519681536424204
domContentLoaded1542190716649546
load1547192016819646
domInteractive24105432713
backgroundConnect86423178
firstReactRender1675432412
getState55111126
initialActions01000
loadScripts1046139211808340
setupStore76116188
uiStartup17712191190410751
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -1.03 KiB (-0.01%)
  • common: 0 Bytes (0.00%)

Merged via the queue into main with commit 7fc280d Feb 5, 2025
73 checks passed
@FrederikBolding FrederikBolding deleted the fb/remove-dead-insight-code branch February 5, 2025 14:20
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2025
@metamaskbot metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants