Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Collect coverage from Snaps components #30129

Merged

Conversation

FrederikBolding
Copy link
Member

@FrederikBolding FrederikBolding commented Feb 5, 2025

Description

A faulty regex caused us to not correctly collect coverage from Snaps components and systems. This PR corrects that regex by adding an end matcher.

Open in GitHub Codespaces

@metamaskbot metamaskbot added team-snaps-platform Snaps Platform team INVALID-PR-TEMPLATE PR's body doesn't match template labels Feb 5, 2025
@FrederikBolding FrederikBolding added this pull request to the merge queue Feb 5, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [f381f7c]
Page Load Metrics (1941 ± 100 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint163125911945211101
domContentLoaded16202500190819895
load163025441941208100
domInteractive27123593215
backgroundConnect1191352612
firstReactRender18101532713
getState596302914
initialActions00000
loadScripts11701903140817282
setupStore693202311
uiStartup181233002290331159
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Merged via the queue into main with commit 8f78340 Feb 5, 2025
81 checks passed
@FrederikBolding FrederikBolding deleted the fb/fix-collect-coverage-from-snaps-components branch February 5, 2025 13:38
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2025
@metamaskbot metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-snaps-platform Snaps Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants