fix: cp-12.12.0 30060 lattice account import issue

[dawnseeker8]

Description

This PR will fix the #30060 user unable to add more than one lattice issue.
The current patch fix is temperately fix, will need to upgrade eth-lattice-keyring library to provide proper fix.

Related issues

Fixes:
#30060

Manual testing steps

1. Install MM Extension
2. Recover from SRP
3. Add hardware device
4. Add Lattice1 hardware wallet and import 3 accounts
5. Verify all 3 accounts are added to the account list

Screenshots/Recordings

Before

Private Zenhub Video

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [a7df2af]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1585 ± 43 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1419	1775	1588	94	45
		domContentLoaded	1404	1750	1562	88	42
		load	1421	1773	1585	89	43
		domInteractive	22	76	32	14	7
		backgroundConnect	12	57	29	16	8
		firstReactRender	15	74	35	25	12
		getState	4	54	11	14	7
		initialActions	0	1	0	0	0
		loadScripts	986	1290	1131	84	40
		setupStore	7	54	15	16	8
		uiStartup	1583	1973	1802	95	46

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 26 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[metamaskbot]

Builds ready [433dce0]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1660 ± 51 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1539	1946	1666	105	51
		domContentLoaded	1499	1932	1644	105	51
		load	1533	1946	1660	106	51
		domInteractive	17	169	51	36	18
		backgroundConnect	9	47	18	11	5
		firstReactRender	16	80	38	25	12
		getState	5	54	15	17	8
		initialActions	0	1	0	0	0
		loadScripts	1055	1383	1182	86	41
		setupStore	7	58	20	20	9
		uiStartup	1714	2246	1893	127	61

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 26 Bytes (0.00%)
• ui: 0 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[itsyoboieltr]

LGTM!

[vivek-consensys]

Tested locally and able to add 5x Lattice1 accounts with no errors.
https://github.com/user-attachments/assets/3a5dd7d6-3645-4fa7-8cd2-ca3d3c7caf8d

[mikesposito]

It looks like the entire index.js was prettified, making changes a little hard to read through - is there a way we can patch the package without prettifying it?

[dawnseeker8]

It looks like the entire index.js was prettified, making changes a little hard to read through - is there a way we can patch the package without prettifying it?

I think this is done by yarn commit patch command. actually the only change in that file is just below addAccounts() method.:

-    return this.accounts;
+    });
+
+    /** PATCH: Patch the account array to return the new account */
+    return [this.accounts[this.accounts.length - 1]];

The patch only change the return of addAccounts() from whole list of stored this.accounts to last added new account, since our metamask-controller code in unlockHardwareWalletAccount line 5023, without my change, the address value will always be the first account in the this.account list which cause Account name already exist

[gantunesr]

I assume a lot of changes on this patch were due to the linter, which is not ideal. The fix itself looks good, we should revert all the linter changes after the release to keep the patch simple

[dawnseeker8]

I assume a lot of changes on this patch were due to the linter, which is not ideal. The fix itself looks good, we should revert all the linter changes after the release to keep the patch simple

yea, i think the best approach is ask lattice team to release a new version with my PR from my fork, i will contact them to ask them release as soon as possible so that we dont need to use patch anymore.