test: pin Firefox version temporarily to 134 until artifacts `tar.bz2… #30126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` are available again (or a fix is provided) (#30112) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Firefox specs started failing with the error: ``` <failure message="Unable to obtain browser driver. For more information on how to install drivers see https://www.selenium.dev/documentation/webdriver/troubleshooting/errors/driver_location/. Error: Error executing command for /home/circleci/project/node_modules/selenium-webdriver/bin/linux/selenium-manager with --browser,firefox,--output,json,--browser-path,/opt/firefox/firefox: Unsuccessful response (404 Not Found) for URL https://ftp.mozilla.org/pub/firefox/releases/135.0/linux-x86_64/en-US/firefox-135.0.tar.bz2 (Ran on CircleCI Node 0 of 24, Job test-e2e-firefox)" type="Error">< From @itsyoboieltr : `It seems like firefox changed the way their releases work, so selenium cannot get the tar.` Context: https://consensys.slack.com/archives/CTQAGKY5V/p1738664570174839 [](https://codespaces.new/MetaMask/metamask-extension/pull/30112?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** I re-enabled FF specs and tested this in [another branch](#30122): 1. Check ci, how FF tests started running normally [here](https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/122355/workflows/f1806a6c-b9ef-4a27-8291-fc6c71f0c519/jobs/4518553) I canceled the job once I saw that the browser was successfully downloaded and specs started running ## **Screenshots/Recordings**  ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
chloeYue
approved these changes
Feb 5, 2025
](https://codespaces.new/MetaMask/metamask-extension/pull/30112?quickstart=1){kind=link}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…` are available again (or a fix is provided) (#30112)
Description
Firefox specs started failing with the error:
The problem is that the artifact ending with
tar.bz2is not in present in the version 135.0, whereas it was always in previous versions, which we relied on.https://ftp.mozilla.org/pub/firefox/releases/135.0/linux-x86_64/en-US/
From @itsyoboieltr :
It seems like firefox changed the way their releases work, so selenium cannot get the tar.Context:
https://consensys.slack.com/archives/CTQAGKY5V/p1738664570174839
Related issues
Fixes:
Manual testing steps
I re-enabled FF specs and tested this in another
branch:
I canceled the job once I saw that the browser was successfully downloaded and specs started running
Screenshots/Recordings
Pre-merge author checklist
Standards.
Pre-merge reviewer checklist
Description
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist