Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update selenium #30124

Merged
merged 10 commits into from
Feb 7, 2025
Merged

chore: update selenium #30124

merged 10 commits into from
Feb 7, 2025

Conversation

pnarayanaswamy
Copy link
Contributor

@pnarayanaswamy pnarayanaswamy commented Feb 5, 2025

Description

Updates the selenium-webdriver package to the latest version 4.28.1.
Also updates the @types/selenium-webdriver to version 4.1.28
Adds 'HTMLFormElements' to the scuttling exclusions for chromedriver

Open in GitHub Codespaces

Related issues

Fixes: 4122

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-qa QA team label Feb 5, 2025
Copy link

socket-security bot commented Feb 5, 2025

New and updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@bazel/[email protected] environment, filesystem 0 17.4 kB alexeagle
npm/@types/[email protected] 🔁 npm/@types/[email protected] None 0 269 kB types
npm/[email protected] 🔁 npm/[email protected] None 0 18.1 MB diemol
npm/[email protected] 🔁 npm/[email protected] None 0 54.4 kB raszi

View full report↗︎

@pnarayanaswamy pnarayanaswamy marked this pull request as ready for review February 6, 2025 14:08
@metamaskbot
Copy link
Collaborator

Builds ready [dec8202]
Page Load Metrics (1724 ± 74 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint41219471646314151
domContentLoaded14282040170215675
load14392050172415574
domInteractive23107442613
backgroundConnect96628199
firstReactRender1677372512
getState56320209
initialActions01000
loadScripts9791532121413866
setupStore75719189
uiStartup16202301195719192
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@hjetpoluru hjetpoluru self-requested a review February 6, 2025 18:37
@pnarayanaswamy pnarayanaswamy added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit ecc7bd0 Feb 7, 2025
78 checks passed
@pnarayanaswamy pnarayanaswamy deleted the ff-selenium branch February 7, 2025 10:01
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2025
@metamaskbot metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-qa QA team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants