Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Cleanup extension e2e tests code #30121

Merged
merged 2 commits into from
Feb 7, 2025
Merged

test: Cleanup extension e2e tests code #30121

merged 2 commits into from
Feb 7, 2025

Conversation

chloeYue
Copy link
Contributor

@chloeYue chloeYue commented Feb 5, 2025

Description

As we have removed the confirmation screen legacy UI component, some e2e test code has become unused. This PR removes them.

Our approach is to never keep dead code in the test codebase, as it adds unnecessary complexity, making maintenance and debugging more difficult.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

Check code readability, make sure tests pass.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@chloeYue chloeYue added team-extension-platform Extension Platform team e2e-test End to end test for the MetaMask extension team-qa QA team labels Feb 5, 2025
@chloeYue chloeYue requested a review from a team February 5, 2025 04:00
@chloeYue chloeYue self-assigned this Feb 5, 2025
@chloeYue chloeYue marked this pull request as draft February 5, 2025 04:00
Copy link
Contributor

github-actions bot commented Feb 5, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chloeYue chloeYue changed the title test: cleanup test: cleanup e2e tests code Feb 5, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [66d3f70]
Page Load Metrics (1927 ± 86 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28922761835395190
domContentLoaded15792262190317886
load15902275192717986
domInteractive196337126
backgroundConnect127429199
firstReactRender1794402612
getState662242110
initialActions01000
loadScripts11031680137915374
setupStore95922199
uiStartup18272563221920498
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@chloeYue chloeYue changed the title test: cleanup e2e tests code test: Cleanup extension e2e tests code Feb 5, 2025
@chloeYue chloeYue marked this pull request as ready for review February 5, 2025 10:00
@DDDDDanica
Copy link
Contributor

LGTM!

@metamaskbot
Copy link
Collaborator

Builds ready [537e91f]
Page Load Metrics (1816 ± 65 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint28920571730352169
domContentLoaded15752100178713665
load16212123181613565
domInteractive277936126
backgroundConnect146337188
firstReactRender1781322110
getState686252512
initialActions01000
loadScripts11041581131012761
setupStore85715136
uiStartup18392623211318991
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@HowardBraham HowardBraham added this pull request to the merge queue Feb 7, 2025
Merged via the queue into main with commit 0c697c8 Feb 7, 2025
72 checks passed
@HowardBraham HowardBraham deleted the chloe-cleanup branch February 7, 2025 14:48
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2025
@metamaskbot metamaskbot added the release-12.13.0 Issue or pull request that will be included in release 12.13.0 label Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
e2e-test End to end test for the MetaMask extension release-12.13.0 Issue or pull request that will be included in release 12.13.0 team-extension-platform Extension Platform team team-qa QA team
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants