-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix snaps permission flow ui #30116
Conversation
[Caip25EndowmentPermissionName]: ({ t, isLegacySwitchEthereumChain }) => { | ||
if (isLegacySwitchEthereumChain) { | ||
return { | ||
label: t('permission_walletSwitchEthereumChain'), | ||
leftIcon: IconName.Wifi, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are now pulling the flag directly from the request object provided by calling approvalController.addAndShowApprovalRequest
for wallet_switchEthereumChain
legacy request.
For all other flows, UI should remain untouched now with no unpredictable behaviour 👍🏾
Builds ready [43fbe34]
Page Load Metrics (1576 ± 75 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Pull Request is not mergeable
Issue described here
This commit fixes the snaps permission flow UI bug detected after #29824
Screenshots after fix:
Description
Related issues
Fixes: #30087
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist