-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: pin Firefox version temporarily to 134 until artifacts tar.bz2
are available again (or a fix is provided)
#30112
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [23b6ff6]
Page Load Metrics (2040 ± 193 ms)
Bundle size diffs
|
@MetaMask/policy-reviewers There's no fundamental changes in policy, it is just for disabling e2e tests in ff as a temporary solution. Thanks for reviewing 🙏🏻 |
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/30122?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
fd17af7
tar.bz2
are available again (or a fix is provided)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Builds ready [fd17af7]
Page Load Metrics (1742 ± 54 ms)
Bundle size diffs
|
Description
Firefox specs started failing with the error:
The problem is that the artifact ending with
tar.bz2
is not in present in the version 135.0, whereas it was always in previous versions, which we relied on.https://ftp.mozilla.org/pub/firefox/releases/135.0/linux-x86_64/en-US/
From @itsyoboieltr :
It seems like firefox changed the way their releases work, so selenium cannot get the tar.
Context: https://consensys.slack.com/archives/CTQAGKY5V/p1738664570174839
Related issues
Fixes:
Manual testing steps
I re-enabled FF specs and tested this in another branch:
I canceled the job once I saw that the browser was successfully downloaded and specs started running
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist