Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Unable to add accounts from multiple Ledger devices #30519

Closed
sleepytanya opened this issue Feb 22, 2025 · 3 comments
Closed

[Bug]: Unable to add accounts from multiple Ledger devices #30519

sleepytanya opened this issue Feb 22, 2025 · 3 comments
Labels
regression-prod-12.12.0 Regression bug that was found in production in release 12.12.0 Sev3-low Low severity; minimal to no impact upon users team-accounts team-hardware-wallets type-bug Something isn't working

Comments

@sleepytanya
Copy link
Contributor

sleepytanya commented Feb 22, 2025

Describe the bug

In 12.11.0:

  • after adding account from Ledger Nano X, I can't add an account from the Ledger Nano S, error Value must be a hexadecimal string, starting with "Ox".;
  • I'm able to connect the previously connected Ledger Nano X
Image

In 12.12.0 and 12.13.0 after trying to add an account for another Ledger device, user is unable to add accounts for both devices:

  • after adding account from Ledger Nano X, I can't add an account from the Ledger Nano S, extension after first click displays error Account name already exist, after trying to add another account from the same device the error is setAccountLabel requires a valid address, got undefined
  • I can't add an account from the previously connected Ledger Nano X (same errors)
Image

Expected behavior

Accounts from multiple Ledger hardwallets can be connected to MetaMask

Screenshots/Recordings

Steps to reproduce

  1. Have two physical Ledger devices
  2. Connect accounts

Error messages or log output

Detection stage

In production (default)

Version

12.12.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@sleepytanya sleepytanya added regression-prod-12.11.0 Regression bug that was found in production in release 12.11.0 regression-prod-12.12 Regression bug that was found in production in release 12.12 regression-RC-12.13.0 Regression bug that was found in release candidate (RC) for release 12.13.0 Sev2-normal Normal severity; minor loss of service or inconvenience. team-accounts team-hardware-wallets type-bug Something isn't working labels Feb 22, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Feb 22, 2025
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Feb 22, 2025
@metamaskbot metamaskbot added regression-prod-12.12.0 Regression bug that was found in production in release 12.12.0 and removed regression-prod-12.11.0 Regression bug that was found in production in release 12.11.0 regression-RC-12.13.0 Regression bug that was found in release candidate (RC) for release 12.13.0 regression-prod-12.12 Regression bug that was found in production in release 12.12 labels Feb 22, 2025
@vivek-consensys
Copy link

@sleepytanya This is a change that we implemented as the new Ledger SDK will also require this as it does not support multiple devices. Users will have to remove the existing account from a specific Ledger device to add another. cc. @angelcheung22

@vivek-consensys
Copy link

Error handling should be same as MM Mobile:- 'Multiple devices not supported yet, please forget your previous device first before adding a new one'

Image

@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Feb 24, 2025
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Feb 24, 2025
@angelcheung22 angelcheung22 reopened this Feb 24, 2025
@github-project-automation github-project-automation bot moved this from Fixed to To be fixed in Bugs by team Feb 24, 2025
@angelcheung22 angelcheung22 added Sev3-low Low severity; minimal to no impact upon users and removed Sev2-normal Normal severity; minor loss of service or inconvenience. labels Feb 24, 2025
@vivek-consensys
Copy link

vivek-consensys commented Feb 24, 2025

Closing this issue as we have already a ticket in place to not allow users to be able to add multiple Ledger devices without removing the existing one with the same copyright used in Mobile.

@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-prod-12.12.0 Regression bug that was found in production in release 12.12.0 Sev3-low Low severity; minimal to no impact upon users team-accounts team-hardware-wallets type-bug Something isn't working
Projects
Archived in project
Status: Fixed
Development

No branches or pull requests

4 participants