-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Aggregated multichain balance (Flask) #30516
Open
gambinish
wants to merge
74
commits into
main
Choose a base branch
from
feat/aggregated-multichain-balance
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+310
−68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k-extension into feat/spl-token-rates-v3
…into reusable selector
…k-extension into feat/spl-token-rates-v3
…k-extension into feat/spl-token-rates-v3
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [016a843]
Page Load Metrics (1885 ± 97 ms)
|
darkwing
reviewed
Feb 22, 2025
Builds ready [4e46673]
Page Load Metrics (1468 ± 26 ms)
|
Builds ready [5823363]
Page Load Metrics (1800 ± 99 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Great work! Should this also be used in the account-list-item component to similarly display the aggregated fiat balance for the solana account? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds aggregated balance to coin-overview under flask builds.
I've opted to begin a new component
AggregatedBalance
to handle the value here. The existingcoin-overview
->UserPreferencedCurrencyDisplay
->currencyDisplay
->useCurrencyDisplay
->currency-formatter
chain felt like it was a lot of abstraction for what the component needed to do. I'm maintaining the existing abstraction withLegacyAggregatedBalance
for evm, but hoping that we can slowly migrate to this new component shortly.Related issues
Fixes: Solana effort
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist