Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Aggregated multichain balance (Flask) #30516

Open
wants to merge 74 commits into
base: main
Choose a base branch
from

Conversation

gambinish
Copy link
Contributor

@gambinish gambinish commented Feb 22, 2025

Description

Adds aggregated balance to coin-overview under flask builds.

I've opted to begin a new component AggregatedBalance to handle the value here. The existing coin-overview -> UserPreferencedCurrencyDisplay -> currencyDisplay -> useCurrencyDisplay -> currency-formatter chain felt like it was a lot of abstraction for what the component needed to do. I'm maintaining the existing abstraction with LegacyAggregatedBalance for evm, but hoping that we can slowly migrate to this new component shortly.

Open in GitHub Codespaces

Related issues

Fixes: Solana effort

Manual testing steps

  1. When "Show native currency as primary balance" toggle is true, SOL native token balance will display
  2. When false, aggregated fiat balance of all SPL tokens will display

Screenshots/Recordings

Screenshot 2025-02-24 at 7 48 32 PM Screenshot 2025-02-24 at 7 50 52 PM

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [016a843]
Page Load Metrics (1885 ± 97 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14762321188520397
domContentLoaded14682278185119091
load14882319188520297
domInteractive26162553617
backgroundConnect1098342512
firstReactRender148027178
getState488212311
initialActions00000
loadScripts10411710137516579
setupStore88019199
uiStartup176826112138222107

@metamaskbot
Copy link
Collaborator

Builds ready [4e46673]
Page Load Metrics (1468 ± 26 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1358159714646230
domContentLoaded1348158714465828
load1361159914685526
domInteractive207933157
backgroundConnect126022115
firstReactRender1472292210
getState666202010
initialActions01000
loadScripts962121310585828
setupStore76418199
uiStartup1542181316655727

Base automatically changed from feat/spl-token-rates-v3 to main February 24, 2025 17:47
@gambinish gambinish marked this pull request as ready for review February 24, 2025 22:45
@gambinish gambinish requested review from a team as code owners February 24, 2025 22:46
@gambinish gambinish requested a review from darkwing February 25, 2025 03:56
@gambinish gambinish changed the title feat: Aggregated multichain balance feat: Aggregated multichain balance (Solana) Feb 25, 2025
@gambinish gambinish changed the title feat: Aggregated multichain balance (Solana) feat: Aggregated multichain balance (Flask) Feb 25, 2025
@metamaskbot
Copy link
Collaborator

Builds ready [5823363]
Page Load Metrics (1800 ± 99 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint27223261554545262
domContentLoaded150822491771211101
load15292258180020699
domInteractive29145463215
backgroundConnect1294392311
firstReactRender1591362411
getState580222612
initialActions01000
loadScripts11041788132218489
setupStore75719178
uiStartup175625532077245118
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 4.91 KiB (0.06%)
  • common: 142 Bytes (0.00%)

@sahar-fehri
Copy link
Contributor

Great work! Should this also be used in the account-list-item component to similarly display the aggregated fiat balance for the solana account?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants