Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User trait fix old commit #30135

Closed
wants to merge 6 commits into from
Closed

User trait fix old commit #30135

wants to merge 6 commits into from

Conversation

danjm
Copy link
Contributor

@danjm danjm commented Feb 5, 2025

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-extension-platform Extension Platform team label Feb 5, 2025
@danjm danjm force-pushed the user-trait-fix-old-commit branch from 1aa1af1 to d8fbdc8 Compare February 5, 2025 16:05
@danjm danjm force-pushed the user-trait-fix-old-commit branch from d8fbdc8 to e003d9b Compare February 5, 2025 16:07
@DDDDDanica DDDDDanica force-pushed the user-trait-fix-old-commit branch 4 times, most recently from 29d666b to ca9f335 Compare February 5, 2025 19:43
@metamaskbot
Copy link
Collaborator

Builds ready [ca9f335]

@DDDDDanica DDDDDanica force-pushed the user-trait-fix-old-commit branch 4 times, most recently from 7bebd53 to d3ab223 Compare February 5, 2025 21:17
@metamaskbot
Copy link
Collaborator

Builds ready [7bebd53]

@DDDDDanica DDDDDanica force-pushed the user-trait-fix-old-commit branch from d3ab223 to f3c1bf4 Compare February 5, 2025 21:30
@metamaskbot
Copy link
Collaborator

Builds ready [f3c1bf4]

@DDDDDanica DDDDDanica force-pushed the user-trait-fix-old-commit branch 3 times, most recently from 60cf105 to 298e1e9 Compare February 5, 2025 23:13
@DDDDDanica DDDDDanica force-pushed the user-trait-fix-old-commit branch from 298e1e9 to 3570861 Compare February 5, 2025 23:39
@metamaskbot
Copy link
Collaborator

Builds ready [3570861]

@danjm danjm closed this Feb 11, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
team-extension-platform Extension Platform team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants