feat: Delete legacy transaction confirmation code

[pedronfigueiredo]

Description

The goal of this PR is to remove as much dead code as possible related to the transaction confirmations that predate the redesign.

• From ConfirmTransaction component:

  • ConfirmDeployContract
  • ConfirmSendEther
  • ConfirmContractInteraction

• From ConfirmTokenTransactionSwitch and ConfirmTransactionSwitch:

  • ConfirmApprove
  • ConfirmTokenTransactionBase
  • ConfirmSendToken
  • ConfirmTransactionBase, TokenAllowance and ConfirmApproveContent that were used by the components above.

• GasDisplay, ConfirmGasDisplay and ConfirmLegacyGasDisplay that were no longer used

• Edit custom nonce settings toggle, selector, action and state property migration, and associated custom-nonce component for the legacy transactions.

• Unit tests, storybook stories, styles and localization files associated with the removed files.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/4025

Manual testing steps

Confirm the remaining confirmations (Transactions, Signatures, Encrypt / Decrypt, Add/Switch Ethereum Chain Snaps) still work.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [b5c9fc8]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1783 ± 105 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1458	2320	1782	226	108
		domContentLoaded	1448	2253	1750	212	102
		load	1461	2271	1783	218	105
		domInteractive	25	118	44	24	11
		backgroundConnect	11	87	30	22	11
		firstReactRender	16	102	44	29	14
		getState	5	60	19	20	10
		initialActions	0	0	0	0	0
		loadScripts	1010	1773	1299	194	93
		setupStore	8	93	17	21	10
		uiStartup	1701	2806	2092	292	140

Bundle size diffs [🚀 Bundle size reduced!]

• background: 0 Bytes (0.00%)
• ui: -196.6 KiB (-2.43%)
• common: -5.92 KiB (-0.06%)

[socket-security]

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@emotion/[email protected], npm/@emotion/[email protected], npm/@emotion/[email protected], npm/@emotion/[email protected], npm/@emotion/[email protected], npm/@emotion/[email protected], npm/@emotion/[email protected], npm/@emotion/[email protected], npm/@emotion/[email protected], npm/@storybook/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

[pedronfigueiredo]

@metamaskbot update-policies

[metamaskbot]

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

[metamaskbot]

Builds ready [9d7ada6]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1813 ± 66 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1618	2230	1819	136	65
		domContentLoaded	1602	2219	1783	134	64
		load	1620	2230	1813	137	66
		domInteractive	26	99	41	21	10
		backgroundConnect	11	95	37	26	13
		firstReactRender	17	96	50	28	13
		getState	5	88	23	25	12
		initialActions	0	1	0	0	0
		loadScripts	1097	1593	1295	108	52
		setupStore	8	62	15	15	7
		uiStartup	1817	2637	2114	225	108

Bundle size diffs [🚀 Bundle size reduced!]

• background: 0 Bytes (0.00%)
• ui: -196.69 KiB (-2.43%)
• common: -5.96 KiB (-0.07%)

[pedronfigueiredo]

@metamaskbot update-policies

[metamaskbot]

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

[pedronfigueiredo]

@metamaskbot update-policies

[metamaskbot]

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

[pedronfigueiredo]

@metamaskbot update-policies

[metamaskbot]

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

[metamaskbot]

Builds ready [ffa5475]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1616 ± 63 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	409	1857	1553	292	140
		domContentLoaded	1436	1849	1593	121	58
		load	1446	1865	1616	131	63
		domInteractive	23	92	33	19	9
		backgroundConnect	8	86	23	19	9
		firstReactRender	15	98	46	29	14
		getState	4	75	19	21	10
		initialActions	0	1	0	0	0
		loadScripts	1012	1386	1150	106	51
		setupStore	8	61	22	21	10
		uiStartup	1662	2532	1887	226	108

Bundle size diffs [🚀 Bundle size reduced!]

• background: 444 Bytes (0.01%)
• ui: -197.79 KiB (-2.44%)
• common: -6.61 KiB (-0.07%)

[metamaskbot]

Builds ready [e12f346]

• builds: chrome, firefox
• builds (flask): chrome, firefox
• builds (MMI): chrome
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4, 5, 6, 7
  • common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13
  • ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12
  • content-script: 0
  • offscreen: 0

Page Load Metrics (1534 ± 36 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1426	1672	1537	77	37
		domContentLoaded	1398	1621	1509	68	33
		load	1427	1668	1534	75	36
		domInteractive	15	70	31	15	7
		backgroundConnect	8	84	26	22	11
		firstReactRender	14	92	35	25	12
		getState	4	48	11	12	6
		initialActions	0	0	0	0	0
		loadScripts	993	1208	1097	67	32
		setupStore	7	64	15	16	8
		uiStartup	1577	2152	1756	130	62

Bundle size diffs [🚀 Bundle size reduced!]

• background: 444 Bytes (0.01%)
• ui: -207.89 KiB (-2.57%)
• common: -6.61 KiB (-0.07%)

[pedronfigueiredo]

@MetaMask/policy-reviewers, I believe the policy change results from removing the package @storybook/addon-knobs.

I don't understand why browserify is now added to the policy file.

-  "@storybook/addon-knobs>qs": {
+  "browserify>url>qs": {

[davidmurdoch]

Policy changes are approved. No new permissions added. Only the path to the qs module has changed due to package updates/removals.

[sleepytanya]

@pedronfigueiredo
I don't see 'Customize tx nonce' in the Settings->Advanced (I'm using the dev build):

Screen.Recording.2025-01-31.at.00.32.16.mov

[sleepytanya]

@pedronfigueiredo
Looks like I can't Cancel or Speed up the transaction:
Update: likely not related to this PR as the same issue is present in RC 12.12.0 #30027

Screen.Recording.2025-01-31.at.00.39.30.mov

[naugtur]

@pedronfigueiredo

 -  "@storybook/addon-knobs>qs": {
 +  "browserify>url>qs": {

The change is in the identifier of the qs package. After the dependency tree change, the shortest path in the graph leading to this specific copy of qs is this. It's probably because addon-knobs updated to a major version that was deduplicated to the top before (something else depended on it too) or it got rid of qs altogether.

I'll include a complete explanation of this in the next educational content :) There's a hint of it in the policy review process training currently available in cornerstone.

[pedronfigueiredo]

@pedronfigueiredo I don't see 'Customize tx nonce' in the Settings->Advanced (I'm using the dev build):

@sleepytanya this has been removed on this PR as it was only needed in the old confirmation flows. In the redesigned screens the nonce is always editable as long as advanced details are open and smart transactions are turned off.

[Bdiit]

Nicer 👍