Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add BNB Smart Chain to Smart Transactions description in settings #29833

Merged
merged 16 commits into from
Feb 14, 2025
Merged

fix: Add BNB Smart Chain to Smart Transactions description in settings #29833

merged 16 commits into from
Feb 14, 2025
+7 −49

Conversation

httpJunkie
Copy link
Contributor

@httpJunkie httpJunkie commented Jan 21, 2025 •
edited
Loading

  • update text in _locales json
  • update Snapshot in ui/pages/settings/advanced-tab

Description

update content in Advanced Settings for BSC in the STX section to read:
"Turn on Smart Transactions for more reliable and secure transactions on Ethereum Mainnet and BNB Smart Chain."

Related issues

N/A

Manual testing steps

  1. Load Extension from feature branch
  2. Go to Settings > Advanced > Smart Transactions section
  3. Ensure that text reads:
  • "Turn on Smart Transactions for more reliable and secure transactions on Ethereum Mainnet and BNB Smart Chain."
    instead of:
  • "Turn on Smart Transactions for more reliable and secure transactions on Ethereum Mainnet"

Screenshots/Recordings

Before & After

stx_before stx_after

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@httpJunkie
fix: add BNB Smart Chain to Smart Transactions description in settings.
fe4de68 
- update text in _locales json
- update Snapshot in `ui/pages/settings/advanced-tab`
- update Snapshot in `ui/components/app/snaps/snap-ui-address`
- update snapshot in `ui/components/multichain/connect-accounts-modal`
@httpJunkie httpJunkie added the team-transactions Transactions team label Jan 21, 2025
@httpJunkie httpJunkie self-assigned this Jan 21, 2025
@httpJunkie httpJunkie requested review from a team as code owners January 21, 2025 19:06
@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@httpJunkie
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@metamaskbot
Copy link
Collaborator

Builds ready [3f8b199]
Page Load Metrics (1601 ± 42 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31318241532294141
domContentLoaded1414175715788742
load1430182916018842
domInteractive219639199
backgroundConnect57222199
firstReactRender16105453115
getState480182411
initialActions01000
loadScripts1017132611638139
setupStore549994
uiStartup168226511878220106
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 20 Bytes (0.00%)

@httpJunkie
fix: need to add a new message rather than update the old
df6ee99 
Then update the references from old value `stxOptInDescription` to `stxOptInEthereumBnbDescription`
@httpJunkie
Merge branch 'main' into fix/add-bnb-chain-to-stx-description
aa83d7f
@metamaskbot
Copy link
Collaborator

Builds ready [aa83d7f]
Page Load Metrics (1968 ± 125 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint58124561879385185
domContentLoaded154424191932255123
load155424321968260125
domInteractive26148563416
backgroundConnect1292462311
firstReactRender17101492713
getState58320199
initialActions01000
loadScripts110618631422220106
setupStore86014115
uiStartup180027882299311149
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 22 Bytes (0.00%)
  • common: 156 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [ca51742]
Page Load Metrics (1665 ± 60 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14661935166512962
domContentLoaded14581921164412359
load14671937166512460
domInteractive247034115
backgroundConnect86326189
firstReactRender1681342411
getState45517178
initialActions00000
loadScripts1001136411829445
setupStore76222199
uiStartup16472210188712660
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 22 Bytes (0.00%)
  • common: 156 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [f28f676]
Page Load Metrics (1643 ± 82 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint14222108164717082
domContentLoaded14092090161016780
load14172106164317082
domInteractive23121382612
backgroundConnect890292512
firstReactRender1599392914
getState469242412
initialActions01000
loadScripts9961558114913464
setupStore65315157
uiStartup166727961905243117
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 22 Bytes (0.00%)
  • common: 31 Bytes (0.00%)

dan437
dan437 previously approved these changes Feb 7, 2025
View reviewed changes
@metamaskbot
Copy link
Collaborator

Builds ready [ad72a7a]
Page Load Metrics (1891 ± 88 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint52522841809340163
domContentLoaded15492269186118187
load15582287189118488
domInteractive23107442512
backgroundConnect1179332411
firstReactRender1675382311
getState56021199
initialActions01000
loadScripts11181629137014971
setupStore86618189
uiStartup179126002145210101
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 22 Bytes (0.00%)
  • common: 31 Bytes (0.00%)

@metamaskbot
Copy link
Collaborator

Builds ready [5accf1c]
Page Load Metrics (1850 ± 96 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint30022341698464223
domContentLoaded14532152181719393
load14622233185020096
domInteractive2396482412
backgroundConnect9167374421
firstReactRender1599452713
getState491212311
initialActions01000
loadScripts10411593130315072
setupStore86919188
uiStartup163127502112260125
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 22 Bytes (0.00%)
  • common: 31 Bytes (0.00%)

darkwing
darkwing previously approved these changes Feb 14, 2025
View reviewed changes
@httpJunkie httpJunkie requested a review from hmalik88 February 14, 2025 17:14
@metamaskbot
Copy link
Collaborator

Builds ready [84dadc2]
Page Load Metrics (1743 ± 75 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint24120451643350168
domContentLoaded14732081171315976
load15502087174315775
domInteractive26106412010
backgroundConnect980332412
firstReactRender14101442713
getState55211105
initialActions01000
loadScripts10411568123914670
setupStore76019199
uiStartup17312378201319192
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 22 Bytes (0.00%)
  • common: 31 Bytes (0.00%)

@httpJunkie httpJunkie dismissed stale reviews from darkwing and dan437 via 3829bcd February 14, 2025 18:04
@metamaskbot
Copy link
Collaborator

Builds ready [3829bcd]
Page Load Metrics (1790 ± 82 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint15522168178217785
domContentLoaded15112149175817483
load15522165179017082
domInteractive22118422512
backgroundConnect106426199
firstReactRender1477292311
getState575232311
initialActions00000
loadScripts11051655129914972
setupStore883232311
uiStartup177525312074209100
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 22 Bytes (0.00%)
  • common: 31 Bytes (0.00%)

@httpJunkie httpJunkie added this pull request to the merge queue Feb 14, 2025
Merged via the queue into main with commit d6e21aa Feb 14, 2025
73 checks passed
@httpJunkie httpJunkie deleted the fix/add-bnb-chain-to-stx-description branch February 14, 2025 22:00
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2025
@metamaskbot metamaskbot added the release-12.14.0 Issue or pull request that will be included in release 12.14.0 label Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@darkwing darkwing darkwing approved these changes

@klejeune klejeune klejeune approved these changes

@dan437 dan437 Awaiting requested review from dan437

Assignees

@httpJunkie httpJunkie

Labels
release-12.14.0 Issue or pull request that will be included in release 12.14.0 team-transactions Transactions team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@httpJunkie @metamaskbot @darkwing @klejeune @dan437