-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Design Quality]: Update segmented tab styling #26190
Comments
@amandaye0h I’m creating a PR to fix the tab styles as indicated here. I have two questions:
|
hey @amandaye0h thanks for your response :) I think I have resolved this issue in this PR #26190 but I’m still convinced that an edge case remains where a Tab group has only one tab. Do you think the style I’ve proposed could work in this case? Or do you think the single tab should still be highlighted as a tab (with blue font and a blue bottom border)? |
This is the PR with a proposed solution to standardize the tab style #29652 |
Yeah, I think it's an acceptable solution for now — best case scenario is that users don't see the tab at all. I'm ok with the white text if it's too complex to remove the tab altogether. The blue text + blue border is visually way too loud. |
## **Description** This PR updates the style of the `ui/components/ui/tabs/tabs.component.js` component and removes some custom classes used to override the style in various parts of the site (particularly on the home page and the notifications page). This ensures a consistent style for the tabs. [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29652?quickstart=1) ## **Related issues** Original request: #26190 ## **Manual testing steps** The tabs tested are those indicated in this issue: #28910. However, some of them seem to no longer be in use (for example, the “snap” tab in the permissions page should no longer exist, as it now has its own dedicated page). ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** ### **After** <img width="453" alt="Screenshot 2025-01-13 at 09 49 49" src="https://github.com/user-attachments/assets/55aeaf12-fa5e-4c8c-8f4b-4ab9bfab29ff" /> <img width="366" alt="Screenshot 2025-01-12 at 23 28 37" src="https://github.com/user-attachments/assets/935de0dc-e0dd-4439-8ec0-754ded9a256b" /> <img width="358" alt="Screenshot 2025-01-12 at 23 28 23" src="https://github.com/user-attachments/assets/fa1cb8b8-97f4-483b-aedc-afdc91d9fb33" /> <img width="361" alt="Screenshot 2025-01-12 at 23 28 08" src="https://github.com/user-attachments/assets/8d9b2414-57f9-48ba-99ec-80e48efe1379" /> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [x] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [x] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
Problem statement
Visually, our tabs look unbalanced and compete for attention with other components. The updated styling strengthens the contrast between primary and secondary elements to help users focus stay focused on key tasks.
Acceptance criteria
text-default
totext-muted
2px solid color: var(--color-text-muted)
4px
padding between tabs has been removedfont-weight = 500 (medium)
for active and inactive tabsTesting
A similar styling is applied in other flows:
Final review
Key screen
Figma link
Related screens
Figma link
Steps to reproduce
Portfolio View
Import tokens
import tokens
Send Flow
Permissions
(Associated with Amon/Hen)
dApp connection page
Error messages or log output
No response
Detection stage
On the development branch
Version
11.16.15
Build type
None
Browser
Brave
Operating system
MacOS
Hardware wallet
No response
Additional context
No response
Severity
No response
The text was updated successfully, but these errors were encountered: