Skip to content

refactor: asset-list and token-list #57415

refactor: asset-list and token-list

refactor: asset-list and token-list #57415

Triggered via pull request February 5, 2025 23:51
Status Failure
Total duration 8m 28s
Artifacts 7

main.yml

on: pull_request
Wait for CircleCI workflow status  /  Wait for CircleCI workflow status
7m 3s
Wait for CircleCI workflow status / Wait for CircleCI workflow status
Build storybook  /  Build storybook
3m 7s
Build storybook / Build storybook
Build beta  /  Build beta
9s
Build beta / Build beta
Matrix: Run tests / Unit tests
Matrix: Validate lavamoat policy webapp / Validate lavamoat policy webapp
Lint workflows  /  Lint workflows
9s
Lint workflows / Lint workflows
Test lint shellcheck  /  Test lint shellcheck
9s
Test lint shellcheck / Test lint shellcheck
Test lint  /  Test lint
6m 32s
Test lint / Test lint
Test lint changelog  /  Test lint changelog
1m 25s
Test lint changelog / Test lint changelog
Test lint lockfile  /  Test lint lockfile
1m 58s
Test lint lockfile / Test lint lockfile
Test yarn dedupe  /  Test yarn dedupe
1m 27s
Test yarn dedupe / Test yarn dedupe
Test deps depcheck  /  Test deps depcheck
1m 51s
Test deps depcheck / Test deps depcheck
Test storybook  /  Test storybook
8m 6s
Test storybook / Test storybook
Validate lavamoat allow scripts  /  Validate lavamoat allow scripts
1m 27s
Validate lavamoat allow scripts / Validate lavamoat allow scripts
Validate lavamoat policy build  /  Validate lavamoat policy build
2m 39s
Validate lavamoat policy build / Validate lavamoat policy build
Run tests  /  Webpack tests
1m 47s
Run tests / Webpack tests
Run tests  /  Integration tests
3m 50s
Run tests / Integration tests
Test circular deps  /  Test circular dependencies
1m 44s
Test circular deps / Test circular dependencies
Test deps audit  /  Test deps audit
1m 36s
Test deps audit / Test deps audit
Runway  /  Runway
Runway / Runway
Publish prerelease  /  Publish prerelease
Publish prerelease / Publish prerelease
Run tests  /  Report coverage
0s
Run tests / Report coverage
All jobs completed
0s
All jobs completed
All jobs pass
0s
All jobs pass
Log merge group failure  /  Log merge group failure
Log merge group failure / Log merge group failure
Fit to window
Zoom out
Zoom in

Annotations

14 errors and 10 warnings
Test circular deps / Test circular dependencies
Process completed with exit code 1.
Test lint / Test lint: ui/components/app/assets/util/importAllDetectedTokens.ts#L12
`@metamask/network-controller` import should occur before import of `../../../../../shared/constants/metametrics`
Test lint / Test lint: ui/components/app/assets/util/importAllDetectedTokens.ts#L30
Unexpected any. Specify a different type
Test lint / Test lint: ui/components/app/assets/util/importAllDetectedTokens.ts#L31
Unexpected any. Specify a different type
Test lint / Test lint: ui/components/app/assets/util/importAllDetectedTokens.ts#L32
Unexpected any. Specify a different type
Test lint / Test lint: ui/pages/asset/util.ts#L103
'parseAssetId' is assigned a value but never used
Test lint / Test lint: ui/selectors/selectors.js#L571
'state' is defined but never used. Allowed unused args must match /[_]+/u
Test lint / Test lint: ui/selectors/selectors.js#L571
Unexpected empty function 'getMultichainTokenBalances'
Test lint / Test lint
Process completed with exit code 1.
Run tests / Unit tests (3)
Process completed with exit code 1.
Wait for CircleCI workflow status / Wait for CircleCI workflow status
Workflow status is 'failing'. Exiting with error.
Wait for CircleCI workflow status / Wait for CircleCI workflow status
Process completed with exit code 1.
All jobs pass
Process completed with exit code 1.
Test lint / Test lint: app/scripts/controllers/swaps/swaps.test.ts#L1265
Some tests seem to be commented
Test lint / Test lint: app/scripts/controllers/swaps/swaps.test.ts#L1286
Some tests seem to be commented
Test lint / Test lint: app/scripts/controllers/swaps/swaps.test.ts#L1306
Some tests seem to be commented
Test lint / Test lint: app/scripts/controllers/swaps/swaps.test.ts#L1390
Some tests seem to be commented
Test lint / Test lint: app/scripts/controllers/swaps/swaps.test.ts#L1406
Some tests seem to be commented
Test lint / Test lint: app/scripts/controllers/swaps/swaps.test.ts#L1429
Some tests seem to be commented
Test lint / Test lint: test/e2e/flask/solana/common-solana.ts#L91
'#fb9f18' Hex color values are not allowed. Consider using design tokens instead. For support reach out to the design system team #metamask-design-system on Slack
Test lint / Test lint: ui/components/app/detected-token/detected-token.js#L117
React Hook useEffect has a missing dependency: 'tokensListDetected'. Either include it or remove the dependency array
Test lint / Test lint: ui/components/app/name/name.stories.tsx#L129
Named exports should not use the name annotation if it is redundant to the name that would be generated by the export name
Test lint / Test lint: ui/components/app/snaps/snap-home-page/snap-home-renderer.js#L49
React Hook useEffect has a missing dependency: 'dispatch'. Either include it or remove the dependency array

Artifacts

Produced during runtime
Name Size
coverage-integration
796 KB
coverage-unit-1
1.06 MB
coverage-unit-2
1.06 MB
coverage-unit-4
1.08 MB
coverage-unit-5
1.05 MB
coverage-unit-6
1.07 MB
coverage-webpack
14.2 KB