From 7ebfedb9e6646bfc5b5ce69906f3a59b1f864dc1 Mon Sep 17 00:00:00 2001 From: charlesedeh021-cell Date: Thu, 27 Aug 2026 23:49:31 +0100 Subject: [PATCH] fix: return error for missing milestone contribution --- contracts/milestones/src/lib.rs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/contracts/milestones/src/lib.rs b/contracts/milestones/src/lib.rs index 285abec..575593b 100644 --- a/contracts/milestones/src/lib.rs +++ b/contracts/milestones/src/lib.rs @@ -463,7 +463,11 @@ fn refund_remaining_budget( for i in 0..milestone.contributor_count { let contribution_key = DataKey::Contribution(milestone_id, i); - let contribution: Contribution = env.storage().persistent().get(&contribution_key).unwrap(); + let contribution: Contribution = env + .storage() + .persistent() + .get(&contribution_key) + .ok_or(Error::MilestoneNotFound)?; let numerator = remaining * contribution.amount; let share = numerator / milestone.total_budget; let remainder = numerator % milestone.total_budget;