Skip to content

docs/access-control-audit.md's per-function tables predate contribute/extend_deadline/keep_alive/get_contribution #154

Description

@chonilius

docs/access-control-audit.md is a "function-by-function audit of every public entrypoint across the three contracts" — but it was written for #30, which closed before #56/#57/#58 (which added extend_deadline, keep_alive, contribute, and get_contribution to escrow and milestones) landed. None of these four functions appear in the audit's per-contract tables. A new contributor reading this doc for "what's the access model for every entrypoint" would miss that these exist at all, let alone whether their access control matches intent (worth double-checking too, e.g. keep_alive's deliberately-no-auth design isn't captured anywhere in this audit framework). Worth a refresh pass adding rows for all four.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programbugSomething isn't workingdocumentationImprovements or additions to documentationhelp wantedExtra attention is neededspikeOpen-ended research/investigation task

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions