Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Theme Editor and Wallpaper Selector #210

Merged
merged 7 commits into from
Dec 8, 2024
Merged

Conversation

BomberFish
Copy link
Member

Merges the aforementioned apps into a singular app; titled "Wallpaper & Style".

Screenshot 2024-12-02 at 17 23 08
Screenshot 2024-12-02 at 17 23 13

@ading2210
Copy link
Member

ading2210 commented Dec 3, 2024

image

It's not very clear that these are supposed to be buttons / tabs.

@ProgrammerIn-wonderland
Copy link
Collaborator

That's true. What would be a better indication?

@BomberFish
Copy link
Member Author

It's not very clear that these are supposed to be buttons / tabs.

Good catch. Perhaps we can make it somewhat like this?

Screenshot 2024-12-02 at 20 37 06
Source: Material Design 2 Docs

@BomberFish
Copy link
Member Author

(It doesn't appear that Matter provides a control for this, we'll have to do it ourselves)

@BomberFish
Copy link
Member Author

A demonstration of the new tab style:
New tabs

@Percslol Percslol self-requested a review December 7, 2024 22:46
@Percslol Percslol merged commit 7be39c1 into main Dec 8, 2024
6 checks passed
@Percslol Percslol deleted the personalization-hub branch December 8, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants