Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node gouping and sub-graphs #53

Open
leissler opened this issue Dec 16, 2021 · 2 comments
Open

Node gouping and sub-graphs #53

leissler opened this issue Dec 16, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@leissler
Copy link

In the dialog example, it seems that there is a grouping feature for nodes. However, when moving the group, it turns out that it's just an empty node around a couple of nodes and doesn't really group them.

So I think that a real grouping feature that treats all nodes in a group as one entity would be very useful since larger graphs quickly become hard to manage. In the best case, such a group should act like a sub-graph with its own inputs and outputs that can be re-used like a function.

@leissler leissler added the enhancement New feature or request label Dec 16, 2021
@McManning
Copy link
Owner

Originally I had written it to behave similar to UE4 blueprints, where nodes are moved with the container comment as you suggested. But I was running into a good amount of undesirable edge cases that made me strip it from the 1.0 release. I've got #5 open already for this one.

For subgraphs, ideally I'd like to keep that as a separate feature where you can extract a group of nodes into a separate graph asset with explicit inputs and outputs - similar to UE4 macros. I know I started on an implementation but it never made it into the samples project. My graphs tend to be pretty lightweight so I haven't spent much time on quality of life features for large graphs.

@leissler
Copy link
Author

I agree that comment-move and sub-graphs are two separate issues. So are you planning on integrating real subgraphs similar to UE4 macros?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants