Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor Usability Issue - non-preferential ports are automatically connected #28

Open
McManning opened this issue Aug 10, 2020 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@McManning
Copy link
Owner

When dragging off a port and connecting a new node - it doesn't prefer ports of the same type over other ports that can accept the value. Instead it just picks the "first" that works.

Use Case: I have an execution flow data type on nodes - but some nodes accept any basic object type (e.g. debug loggers). Since that object type port was added to the node first, it's the first to respond to the request for a connection when instantiating a new node thus creates an incorrect connection.

Instead - the logic should be something like:

  1. Aggregate all ports that could connect to the port we're dragging off from
  2. If any are of the same type, pick that first
  3. If any are of inherited types, pick those next
  4. Pick first of whatever is left over.
@McManning McManning added bug Something isn't working good first issue Good for newcomers labels Aug 10, 2020
@McManning
Copy link
Owner Author

NodeView.GetCompatibleInputPort and NodeView.GetCompatibleOutputPort would be the two places this needs to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant