Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Make drawer storage slotted for CC:T #93

Open
pauliesnug opened this issue Jan 29, 2024 · 4 comments
Open

[Feature]: Make drawer storage slotted for CC:T #93

pauliesnug opened this issue Jan 29, 2024 · 4 comments
Labels
confirmed Confirmed to be happening feature A new feature mod compatablity Relates to a compatibility with some other mod

Comments

@pauliesnug
Copy link

pauliesnug commented Jan 29, 2024

Description of the feature

When using CC: Tweaked adjacent to a drawer from Extended Drawers, Computer Craft doesn't recognize it as a peripheral, so the Computer cannot interact with it. This could be done similarly to how Create implements Computer Craft compatibility: https://github.com/Fabricators-of-Create/Create/blob/mc1.18/fabric/dev/src/main/java/com/simibubi/create/compat/computercraft/implementation/peripherals/SyncedPeripheral.java
image
image

How does it make the mod better?

CC: Tweaked is frequently used to manage storage, so maintaining compatibility with such a popular mod is necessary.

@pauliesnug pauliesnug added feature A new feature unconfirmed Has not yet been confirmed labels Jan 29, 2024
@MattiDragon
Copy link
Owner

This is caused by drawers not currently providing slots because they were coded before the slotted api was added. Once I add support for slotted access to drawers CC:T should be able to interact with them

@MattiDragon MattiDragon added mod compatablity Relates to a compatibility with some other mod confirmed Confirmed to be happening and removed unconfirmed Has not yet been confirmed labels Jan 29, 2024
@MattiDragon MattiDragon changed the title [Feature]: Computer Craft Support [Feature]: Make drawer storage slotted for CC:T Jan 29, 2024
@pauliesnug
Copy link
Author

This is caused by drawers not currently providing slots because they were coded before the slotted api was added. Once I add support for slotted access to drawers CC:T should be able to interact with them

Do you know how easy this would be/an ETA? It is okay if not. I wonder if you could instead make a peripherals compatibility, instead of relying on autodetecting slots, since you already have an ExtendedDrawers API.

@MattiDragon
Copy link
Owner

What additional periferal options would you want from a drawer? Also, there's no ExtendedDrawers API, where did you get that?

@pauliesnug
Copy link
Author

https://github.com/Fabricators-of-Create/Create/blob/mc1.18/fabric/dev/src/main/java/com/simibubi/create/compat/computercraft/implementation/peripherals/SyncedPeripheral.java

Just detection and the ability to grab a specified amount of a specified item, and see all available item amounts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed Confirmed to be happening feature A new feature mod compatablity Relates to a compatibility with some other mod
Projects
None yet
Development

No branches or pull requests

2 participants