Fixed some translation strings for Korean #241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed some words according to National Korean Language Institute, 지난달, 지난주 is correct, instead of 지난 달, 지난 주. http://www.korean.go.kr/front/mcfaq/mcfaqView.do?mn_id=62&mcfaq_seq=1622 And I believe 작년 is more commonly used than 지난해 for "last year"
aerialcombat
changed the title
aerialcombat
commented
Dec 25, 2017
| "An hour ago" = "1시간 전"; | ||
|
|
||
| /* No comment provided by engineer. */ | ||
| "Just now" = "방금 전"; |
Author
There was a problem hiding this comment.
There could be discrepancy in whether 방금 is more commonly used or 방금 전 is more commonly used. 전 means
ago. 방금(A short time ago) already has the meaning 'ago', but according to the National Korean Language Institute, there has been use cases of 방금 전 being used in real life.
http://www.korean.go.kr/front/mcfaq/mcfaqView.do?mn_id=62&mcfaq_seq=2561
This could be more of a preference choice, so... Do what you will
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some words according to National Korean Language Institute,
지난달, 지난주 is correct, instead of 지난 달, 지난 주.
http://www.korean.go.kr/front/mcfaq/mcfaqView.do?mn_id=62&mcfaq_seq=1622
And I believe 작년 is more commonly used than 지난해 for "last year"