-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build independant linting system that will automatically lint all repos any repos in MatrixAI once imported #9
Conversation
…t config file for new linter version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's mostly good, just some minor changes here and there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formatting in this file looks kinda weird. Are you sure the linting rules being used for this repo are also following the standards in other repos?
…tra export for matrixaiPlugin in index.ts
Some notes about using the zeta.house eslint config as the default one - the same parserOptions.project field can't be used across all repos because different repos will have different .tsconfig.json setups. Likely the parserOptions will need to be removed from the shared matrix-ai-config-bundle entirely to ensure compatibility, however this will also break any rules inside the shared config that rely on type-awareness. We could omit the rules that require type-awareness like typescript-eslint's no-floating-promises rule from the shared config and instead place them inside a seperate recommended config like recommended-typeaware or something so that consumer repos can simply import those rules once they have set up their parserOptions |
…rserOptions from config and creating new typeaware specific recommended configs
[ci skip]
… it into the normal recommended ruleset
All repos are to move to ESM and move to the standardized esling.config.mjs. Only a few repos have different linting but I don't think it's necessary. Every repo should have the same standard now. And I have been migrating wherever I see. You should start PRs to repos and migrate incrementally. Start with js-logger. |
I think this issue/PR has major refactoring required. Read #7 (comment) and start on this PR from that angle alone. |
Why close this PR? |
Closed in favour of #10. But still you should preserve code. |
Description
This PR implements a bundled config that includes all of the commonly used MatrixAI linting rules to streamline setting up linting in new repos.
Issues Fixed
Tasks
Final checklist