Skip to content

Update npm root paths for relevant repos #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
4 tasks done
tegefaulkes opened this issue May 12, 2023 · 20 comments
Closed
4 tasks done

Update npm root paths for relevant repos #524

tegefaulkes opened this issue May 12, 2023 · 20 comments
Assignees
Labels
development Standard development r&d:polykey:supporting activity Supporting core activity

Comments

@tegefaulkes
Copy link
Contributor

tegefaulkes commented May 12, 2023

Specification

the npm bin command no longer works since it has been deprecated. This means our shell.nix no longer adds our bin commands for the project to the local environment. This needs to be fixed for some of our repos. I think any repo that defines bin commands in the package.json?

To fix this the following changes need to be replicated. 78a9faa

Additional context

Tasks

  • 1. Determine relevant repos
  • 2. Fix remaining repos
    • js-db
    • js-encryptedfs
@tegefaulkes tegefaulkes added the development Standard development label May 12, 2023
@tegefaulkes tegefaulkes self-assigned this May 12, 2023
@CMCDragonkai
Copy link
Member

All repos needs to fixed. We are using npm bin in all repos.

@CMCDragonkai
Copy link
Member

Including TypeScript-Demo-Lib.

@amydevs when you are working on any of the repos, you should fix them when you see them too.

@CMCDragonkai
Copy link
Member

I've done it for TypeScript-Demo-Lib. Also for the feature branch in js-quic.

@amydevs needs to do it for the new js-mdns.

@CMCDragonkai
Copy link
Member

Done for js-async-cancellable and js-contexts.

@amydevs any update here?

@CMCDragonkai
Copy link
Member

Done for js-async-init.

@CMCDragonkai
Copy link
Member

CMCDragonkai commented Jun 5, 2023

Done for js-resources.

@CMCDragonkai
Copy link
Member

Not yet done for js-errors.

@CMCDragonkai
Copy link
Member

Done for js-timer and js-async-locks.

@CMCDragonkai
Copy link
Member

@amydevs can you identify that this is going to be done for js-mdns.

@CMCDragonkai
Copy link
Member

Done for js-errors.

@CMCDragonkai
Copy link
Member

CMCDragonkai commented Jun 23, 2023

TBD:

  1. js-db
  2. js-encryptedfs
  3. js-id
  4. js-workers
  5. js-logger
  6. Polykey

@CMCDragonkai
Copy link
Member

@amydevs Do you see this notification now?

@amydevs
Copy link
Contributor

amydevs commented Jun 23, 2023

@amydevs can you identify that this is going to be done for js-mdns.

done for js-mdns

@CMCDragonkai
Copy link
Member

I've done for js-id and I upgraded the repo to match the project structure we have in other repos now, it was still on a very old version. It's released as a new version 3.3.6.

@CMCDragonkai
Copy link
Member

I've done it for js-workers and also updated dependencies and released 1.3.7.

@CMCDragonkai
Copy link
Member

Done for js-logger.

@CMCDragonkai
Copy link
Member

Remaining repos is js-db and js-encryptedfs, these 2 use quite a few changes... so it would be interesting to see how they play out.

@CMCDragonkai
Copy link
Member

For js-db, it is being tracked in MatrixAI/js-db#62.

The js-encryptedfs should be a simple upgrade, but it does depend on the js-db being fixed first.

Afterwards, this can be closed.

@CMCDragonkai
Copy link
Member

CMCDragonkai commented Jun 26, 2023

Was done here: MatrixAI/js-encryptedfs#80. Will be released as 3.5.7.

All libraries done. Closing this. Well except the TypeScript Demo native but that's not really relevant anymore with js-db and js-quic being representative native projects.

@CMCDragonkai
Copy link
Member

@tegefaulkes Polykey deps will need to be all updated however all libraries should be updated with the latest now and confirmed to work on node v18.

@CMCDragonkai CMCDragonkai added the r&d:polykey:supporting activity Supporting core activity label Jul 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development r&d:polykey:supporting activity Supporting core activity
Development

No branches or pull requests

3 participants