Skip to content

Commit 81901fb

Browse files
committed
MDEV-35635: START SLAVE UNTIL allows CHANGE MASTER TO options
Restrict START SLAVE UNTIL to slave options disallowing master options START SLAVE UNTIL was allowing both slave and master options, which could cause confusion and misconfigurations. This commit fixes that by restricting it to these valid slave options: - MASTER_LOG_FILE, MASTER_LOG_POS - RELAY_LOG_FILE, RELAY_LOG_POS - MASTER_GTID_POS The parser change replaces `master_file_def` with `slave_until_file_def` in `sql_yacc.yy`, making sure master options like MASTER_USE_GTID and MASTER_DEMOTE_TO_SLAVE aren’t allowed anymore.
1 parent c22ee85 commit 81901fb

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

mysql-test/main/start_slave_until.test

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,15 @@
1010
#
1111
# ==== Method ====
1212
#
13-
# 1. Generate binlog events on the master by creating tables and inserting rows.
14-
# 2. Test various `START SLAVE UNTIL` combinations on the slave:
13+
#
14+
# Test various `START SLAVE UNTIL` combinations on the slave:
1515
# a) Invalid parameter mixes (e.g., GTID, LOG_FILE, LOG_POS) to trigger parsing errors.
1616
# b) Valid parameter combinations that fail due to incomplete or missing replication setup.
1717
#
1818
# ==== Related Bugs ====
1919
# MDEV-35635 – Issues around parsing and invalid parameter combinations in `START SLAVE UNTIL`.
2020

21+
--source include/not_embedded.inc
2122

2223
#
2324
# Invalid query options (using slave+master options)

0 commit comments

Comments
 (0)