Skip to content

Remove the using namespace from headers to eliminate the namespace contamination #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gongminmin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove the using namespace from headers to eliminate the namespace contamination #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions include/implicit_point.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,8 +442,8 @@ class implicitPoint3D_LNC : public genericPoint {
//
//////////////////////////////////////////////////////////////////////////////////////

using namespace ::std;

namespace std
{
ostream& operator<<(ostream& os, const genericPoint& p);

inline ostream& operator<<(ostream& os, const explicitPoint2D& p)
Expand Down Expand Up @@ -483,6 +483,7 @@ inline ostream& operator<<(ostream& os, const implicitPoint3D_LNC& p)
if (p.apapExplicit(e)) return os << e;
else return os << "UNDEF_LNC";
}
}

#include "hand_optimized_predicates.hpp"
#include "implicit_point.hpp"
Expand Down
2 changes: 1 addition & 1 deletion include/implicit_point.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -935,7 +935,7 @@ inline bool implicitPoint3D_LNC::getExactXYZCoordinates(bigrational& x, bigratio
return true;
}

inline ostream& operator<<(ostream& os, const genericPoint& p)
inline std::ostream& operator<<(std::ostream& os, const genericPoint& p)
{
if (p.isExplicit2D()) return os << p.toExplicit2D();
else if (p.isExplicit3D()) return os << p.toExplicit3D();
Expand Down